Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change setting of minimum standard version #1

Open
PPokorski opened this issue Apr 10, 2019 · 2 comments
Open

Change setting of minimum standard version #1

PPokorski opened this issue Apr 10, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@PPokorski
Copy link

Hi! First of all thank you a lot for making this CMake version of Box2D. It was a great help for me to use it in my project, as I do not use premake.
Nevertheless I ran across a problem with this line:

target_compile_features(${PROJECT_NAME} PUBLIC cxx_std_17)

which requires CMake version of at least 3.8 (btw you require 3.5), which isn't bundled with, e.g. Ubuntu 16.04 LTS. I would suggest to change this line to

set_property(TARGET ${PROJECT_NAME} PROPERTY CXX_STANDARD 11)

which would lower the requirements to CMake 3.1, I suppose (3.0 doesn't have CXX_STANDARD property).

Furthermore, original Box2D requires C++11 standard, so that's why I would suggest to keep it that way.

Thanks for your time and response!

@tobanteGaming
Copy link
Owner

@PPokorski

Sorry that I didn't see your issue earlier. It has been a while since I logged into this account.

I changed the minimum standard to C++11 to match the original build. However, I don't really want to add set set_property line since it's old CMake style and discouraged by the developers.

Thanks for taking the time to report these issues.

Toby

@tobanteGaming tobanteGaming added the enhancement New feature or request label May 21, 2019
@PPokorski
Copy link
Author

Thank you for your response. Well, maybe I'm really using an old version of CMake, but it's the one that's default-shipped with Ubuntu 16.04, so I thought it shouldn't be that bad. Well then, the decision is yours :) Thanks anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants