From a486fa53221edd49b1a08f1f7ced5269f0174de9 Mon Sep 17 00:00:00 2001
From: Andy Scherzinger <info@andy-scherzinger.de>
Date: Mon, 6 Jan 2025 18:41:26 +0100
Subject: [PATCH 1/2] fix(a11y): Add content description linked to favorite
 status of the element

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
---
 .../com/owncloud/android/ui/fragment/FileDetailFragment.java    | 2 ++
 app/src/main/res/layout/file_details_fragment.xml               | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/app/src/main/java/com/owncloud/android/ui/fragment/FileDetailFragment.java b/app/src/main/java/com/owncloud/android/ui/fragment/FileDetailFragment.java
index edd6262df96a..a9fd7d134b1f 100644
--- a/app/src/main/java/com/owncloud/android/ui/fragment/FileDetailFragment.java
+++ b/app/src/main/java/com/owncloud/android/ui/fragment/FileDetailFragment.java
@@ -600,10 +600,12 @@ private void setFileModificationTimestamp(OCFile file, boolean showDetailedTimes
     private void setFavoriteIconStatus(boolean isFavorite) {
         if (isFavorite) {
             binding.favorite.setImageDrawable(ResourcesCompat.getDrawable(getResources(), R.drawable.ic_star, null));
+            binding.favorite.setContentDescription(getString(R.string.unset_favorite));
         } else {
             binding.favorite.setImageDrawable(ResourcesCompat.getDrawable(getResources(),
                                                                           R.drawable.ic_star_outline,
                                                                           null));
+            binding.favorite.setContentDescription(getString(R.string.favorite));
         }
     }
 
diff --git a/app/src/main/res/layout/file_details_fragment.xml b/app/src/main/res/layout/file_details_fragment.xml
index 9466d4638d35..c64365632d41 100644
--- a/app/src/main/res/layout/file_details_fragment.xml
+++ b/app/src/main/res/layout/file_details_fragment.xml
@@ -53,7 +53,7 @@
                     android:layout_height="wrap_content"
                     android:layout_marginStart="@dimen/zero"
                     android:layout_marginEnd="@dimen/standard_eighth_margin"
-                    android:contentDescription="@null"
+                    android:contentDescription="@string/favorite"
                     android:src="@drawable/ic_star_outline" />
 
                 <TextView

From 38f1ebd5ff81e04807eec654803ab32dc984af24 Mon Sep 17 00:00:00 2001
From: Andy Scherzinger <info@andy-scherzinger.de>
Date: Mon, 6 Jan 2025 18:44:25 +0100
Subject: [PATCH 2/2] fix(a11y): Add content description for picking contact to
 share with

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
---
 app/src/main/res/layout/file_details_sharing_fragment.xml | 3 ++-
 app/src/main/res/values/strings.xml                       | 1 +
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/app/src/main/res/layout/file_details_sharing_fragment.xml b/app/src/main/res/layout/file_details_sharing_fragment.xml
index ae4d37647d39..be67c5cd5646 100644
--- a/app/src/main/res/layout/file_details_sharing_fragment.xml
+++ b/app/src/main/res/layout/file_details_sharing_fragment.xml
@@ -48,8 +48,9 @@
             android:layout_width="@dimen/minimum_size_for_touchable_area"
             android:layout_height="@dimen/minimum_size_for_touchable_area"
             android:layout_gravity="center_vertical"
-            android:padding="12dp"
             android:layout_marginEnd="@dimen/standard_quarter_margin"
+            android:contentDescription="@string/pick_contact_to_share_with"
+            android:padding="12dp"
             android:src="@drawable/ic_contact_book" />
 
     </LinearLayout>
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
index 8081780ac3f0..4d2893ca24d2 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -1296,4 +1296,5 @@
     <string name="warn_rename_extension">Changing the extension might cause this file to open in a different application</string>
     <string name="auto_upload_gplay">Auto upload behaviour changed</string>
     <string name="auto_upload_gplay_desc">Due to new restrictions imposed by Google, the auto upload feature will no longer be able to automatically remove uploaded files.</string>
+    <string name="pick_contact_to_share_with">Pick contact to share with</string>
 </resources>