Suspect it removes an at-mention link

[annevk]

I think pr-preview is responsible for removing the at-mention link in whatwg/dom#585. It's there when I edit and then a little later it's gone.

[tobie]

Mmm. That sounds like an issue that relates to whether or not the bot has the same access to teams as you do. \o/ for GH permissions. :(

[annevk]

If we make it a member of the WHATWG organization, it should have access to most teams, right?

[tobie]

Thing is, it's a GH app, not a bot, so I need to request the extra permissions. Let me first reach out to GH to make sure that what the issue is.

[tobie]

So there's an open issue on GH's developer forum: https://platform.github.community/t/apps-not-able-to-mention-users-or-teams/2840. In a nutshell, this is a known issue, and it's not clear whether or when it'll be fixed.

[tobie]

Alright. Emailed support. We'll see where that takes us.

Note there's a potential workaround for this if nothing else is possible: add the links to a first comment rather than to the PR's body. Hopefully, it shouldn't be super hard to make the transition if that's the only available solution.

[annevk]

I think I'd prefer everyone learning to not @-mention in OP since it rarely happens anyway (it's usually just the commit message). Getting a notification after you post a PR is rather annoying as it's never quite clear if it's something for you or just a useless bot (the latter is often what's up on web-platform-tests).

[annevk]

Also, thanks a lot for investigating!

[tobie]

I think I'd prefer everyone learning to not @-mention in OP since it rarely happens anyway (it's usually just the commit message).

That said, I would imagine that the notification still gets queued and sent before pr-preview modifies the PR's body.