Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR Preview does not appear to be updating anymore #73

Closed
annevk opened this issue Jun 24, 2020 · 4 comments
Closed

PR Preview does not appear to be updating anymore #73

annevk opened this issue Jun 24, 2020 · 4 comments

Comments

@annevk
Copy link
Contributor

annevk commented Jun 24, 2020

Usually a rebase triggers the attention of the bot, but that doesn't seem to be the case anymore. Noticed this in whatwg/url#513.

WHATWG stopped using Travis recently, could that be related somehow?

@annevk
Copy link
Contributor Author

annevk commented Jun 24, 2020

whatwg/html#5654 is an example where PR Preview didn't do anything.

@tobie
Copy link
Owner

tobie commented Jun 24, 2020

This has been reported elsewhere too. I’m not sure what the issue is and didn’t have the cycles to investigate so far.

@tobie
Copy link
Owner

tobie commented Jun 25, 2020

Fixed by 9fb0a85

@tobie tobie closed this as completed Jun 25, 2020
@tobie
Copy link
Owner

tobie commented Jun 27, 2020

Post Mortem

Current situation

The problem is fully resolved and PR Preview is working normally.
To retrigger a build, please edit the body of the pull request on GitHub (e.g. just a line break).

Duration of outage

Multiple days. The outage was so long because the alert system failed to handle this as an error case.

Cause of outage

The outage was due to Github having deprecated an API endpoint way in advance of the announced plan.

The problem was compounded by the error message being logged not containing the keyword "error". As a result, it wasn't picked by the email alert system, and I wasn't made aware of it until Anne filed an issue against the repository.

Solution

The cause of the outage was quickly identified. The solution was to upgrade to the new API endpoint. This resolved the issue right away.

A support ticket was filed with GitHub to let them know about this issue.

Follow-ups

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants