Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

floorplan urls no longer working #46

Open
T00fy opened this issue Oct 16, 2022 · 1 comment
Open

floorplan urls no longer working #46

T00fy opened this issue Oct 16, 2022 · 1 comment
Labels
bug

Comments

@T00fy
Copy link

T00fy commented Oct 16, 2022 •
edited
Loading

Looks like the xpath changed:

xp_floorplan_url = """//*[@id="floorplanTabs"]/div[2]/div[2]/img/@src"""

id floorplanTabs is no longer available on the main page. On inspecting the elements there appears to be an attempt at obfuscation.

This should be able to be fixed by replacing with:
xp_floorplan_url = """//*[contains(@alt, 'Floorplan')]/@src"""
briggySmalls pushed a commit to briggySmalls/rightmove_webscraper.py that referenced this issue Oct 27, 2022
[toby-p#46] Fix floorplan URL selector
39c192d 
Fix issue reported that finds floorplans now require a different
selector
@toby-p toby-p added the bug label Apr 4, 2023
@toby-p
Copy link
Owner

toby-p commented Apr 4, 2023 •
edited
Loading

Apologies for the delay! I tried running this version and the old version on a test url and neither returned any floorplan URLs. Are you able to provide a sample URL for testing which demonstrates the new version downloading anything?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@T00fy @toby-p