update type checking

Author: toriwei

sqlglot/dialects/duckdb.py

@@ -1183,9 +1183,10 @@ def lower_sql(self, expression: exp.Lower) -> str:
 
                 arg = annotate_types(arg, dialect=self.dialect)
 
-            if arg.is_type(exp.DataType.Type.BINARY):
+            if not arg.is_type(exp.DataType.Type.VARCHAR):
                 expression.this.replace(exp.cast(expression.this, exp.DataType.Type.VARCHAR))
-                return self.sql(exp.cast(expression, exp.DataType.Type.BINARY))
+                if arg.is_type(exp.DataType.Type.BINARY):
+                    return self.sql(exp.cast(expression, exp.DataType.Type.BINARY))
 
             return self.func("LOWER", expression.this)
 

tests/dialects/test_bigquery.py

@@ -847,10 +847,10 @@ def test_bigquery(self):
         )
 
         self.validate_all(
-            "LOWER(b'\x41\x42\x43')",
+            "LOWER(CAST('HELLO' AS BYTES))",
             write={
-                "bigquery": "LOWER(b'\x41\x42\x43')",
-                "duckdb": "CAST(LOWER(CAST(e'\x41\x42\x43' AS TEXT)) AS BLOB)",
+                "bigquery": "LOWER(CAST('HELLO' AS BYTES))",
+                "duckdb": "CAST(LOWER(CAST(CAST('HELLO' AS BLOB) AS TEXT)) AS BLOB)",
             },
         )
         self.validate_all(
@@ -1747,7 +1747,7 @@ def test_bigquery(self):
                 "spark": "CONTAINS(LOWER(a), LOWER(b))",
                 "databricks": "CONTAINS(LOWER(a), LOWER(b))",
                 "snowflake": "CONTAINS(LOWER(a), LOWER(b))",
-                "duckdb": "CONTAINS(LOWER(a), LOWER(b))",
+                "duckdb": "CONTAINS(LOWER(CAST(a AS TEXT)), LOWER(CAST(b AS TEXT)))",
                 "oracle": "CONTAINS(LOWER(a), LOWER(b))",
                 "bigquery": "CONTAINS_SUBSTR(a, b)",
             },