Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color Pattern String parsing fails when no ledn specified #154

Open
todbot opened this issue Dec 30, 2020 · 1 comment
Open

Color Pattern String parsing fails when no ledn specified #154

todbot opened this issue Dec 30, 2020 · 1 comment

Comments

@todbot
Copy link
Owner

todbot commented Dec 30, 2020

Color pattern strings specified via the REST API like:

curl 'http://localhost:8934/blink1/pattern/add?pname=blink3green&pattern=3,%2300ff00,1.5,%23000000,0.5'

were being parsed incorrectly. The ledn parameter should be optional so the following should all be valid:

  • 3,#00ff00,1.5,#000000,0.5 -- no ledn specified
  • 3,#00ff00,1.5,1,#000000,0.5,0 -- ledn specifed for all color steps
  • 3,#00ff00,1.5,1,#000000,0.5 -- ledn specified only sometimes
@todbot
Copy link
Owner Author

todbot commented Dec 30, 2020

Should be fixed with 88a9dc5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant