Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

willDestroyElement needed to do necessary cleanup? #33

Closed
acorncom opened this issue Apr 7, 2016 · 2 comments
Closed

willDestroyElement needed to do necessary cleanup? #33

acorncom opened this issue Apr 7, 2016 · 2 comments
Labels
bug

Comments

@acorncom
Copy link
Contributor

acorncom commented Apr 7, 2016

Per the guides page (https://guides.emberjs.com/v2.4.0/components/the-component-lifecycle/#toc_detaching-and-tearing-down-component-elements-with-code-willdestroyelement-code), it looks like willDestroyElement is necessary to do any cleanup on the dynamic-form component.

Unless I'm missing something, that hook doesn't seem to be implemented here yet ;-)
@toddjordan
Copy link
Owner

Hi @acorncom ! Thanks for raising this. I'll look into it.

@toddjordan toddjordan added the bug label Apr 7, 2016
@toddjordan
Copy link
Owner

Thanks @acorncom I'm combining this issue with one written a few months earlier. #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@acorncom @toddjordan