Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM echo-js pulling older version than stated #119

Open
brianchristopherpeck opened this issue Sep 6, 2017 · 0 comments
Open

NPM echo-js pulling older version than stated #119

brianchristopherpeck opened this issue Sep 6, 2017 · 0 comments

Comments

@brianchristopherpeck
Copy link

brianchristopherpeck commented Sep 6, 2017

npm install echo-js pulls version 1.7.0 instead of 1.7.3 as of 9/5/17. On install, it says
└── [email protected]
The main difference in versions is this line:
var nodes = (context || document).querySelectorAll('[data-echo], [data-echo-background]');
which in the older version being downloaded is this:
var nodes = (context || document).querySelectorAll('img[data-echo], [data-echo-background]');
This forces only images whereas in 1.7.3, the removal of the image selector allows to lazy-load other media like youtube videos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant