Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commonjs way #79

Open
lichunqiang opened this issue Mar 17, 2015 · 1 comment
Open

Commonjs way #79

lichunqiang opened this issue Mar 17, 2015 · 1 comment

Comments

@lichunqiang
Copy link

Hi, I have one question.

In this line: https://github.com/toddmotto/echo/blob/master/dist/echo.js#L8

why not do module.exports = factory(root) ?

By default , I will get a function , I should do call it to get the object.

this is by design?

Thanks!

@mikaelgson
Copy link

+1 - To get around this one needs to invoke with var echo = require('echo')(window); and that does not seem to be be intended by the look of the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants