Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webserver issues related to AUTH_TYPE = None #13

Open
toddrob99 opened this issue Jul 31, 2020 · 0 comments
Open

Webserver issues related to AUTH_TYPE = None #13

toddrob99 opened this issue Jul 31, 2020 · 0 comments
Labels
bug Something isn't working low priority Unlikely to get attention in the short term

Comments

@toddrob99
Copy link
Owner

When "None" is the selected authentication method in System Config, the following issues are known:

  1. After adding a new bot, the platform must be restarted before the bot will be visible in the UI
  2. Upon saving the Web/Security category in System Config, the webserver hangs and the platform must be restarted

Disabling authentication messes with the privilege model. The workarounds put in place to bypass privilege checks work somewhat, but live instances of redball should be run with the "Form" authentication method for the most stability.

@toddrob99 toddrob99 added bug Something isn't working low priority Unlikely to get attention in the short term labels Jul 31, 2020
toddrob99 added a commit that referenced this issue Jul 31, 2020
…game is postponed

FIX: Error when creating bot with AUTH_TYPE=None (see #13 for other known issues)
@toddrob99 toddrob99 mentioned this issue Aug 14, 2020
Merged
toddrob99 added a commit that referenced this issue Aug 14, 2020
### Platform
FIX: Web interface inaccessible when AUTH_TYPE=None
FIX: Basic and None authentication options were not providing access to bots (no user-specific privileges will be honored for either of these options now).
FIX: Error when creating bot with AUTH_TYPE=None (see #13 for other known issues)
FIX: Bot config import fails for big config file
FIX: Refresh token not saved when creating a new reddit authorization
ENH: Game Threads bot label changed to MLB Game Threads
NEW: NFL Game Thread Bot (v1.0-alpha)
VER: 1.0
DBVER: 5

### MLB Game Threads
FIX: Errors in gumbo data patch process
FIX: Comment thread crashing when isScoringPlay is missing from data
FIX: Off thread sometimes unstickied prematurely
FIX: Comment body sometimes lists wrong team as leading
FIX: Scoring play list missing from game/post threads
FIX: Unwanted comments for other team's plays
FIX: Line score showed 0 for new inning earlier than MLB does
FIX: Hide weather conditions if only dummy data is published
FIX: Gameday thread update loop never ends if game gets postponed before game thread is posted and UPDATE_UNTIL="Game thread is posted"
FIX: GameDay and Game threads get posted when bot is restarted after game is postponed
FIX: Error getting bot state when gameday/game threads are skipped
FIX: DH Game 2 game thread does not post
FIX: Straight DH Game 2 shows wrong game date/time
FIX: Game thread update process crashes for DH G2 before G1 is final
FIX: DH Game 2 fails to match DH Game 1 when home/away teams flip
FIX: DH Game 2 using stale status for Game 1
FIX: Query error in check if all postgame threads are submitted (in order to skip gameday thread)
FIX: Bot thought season was suspended if restarted after all games ended
FIX: Don't default pitch count to 0-0 in comment body
ENH: Added custom date format and home/road win/loss and exception prefix settings for for thread titles
ENH: Wait 5 minutes after game 1 is final before posting game thread for straight DH game 2, to hopefully have updated records for thread title
ENH: Include game status in gameday thread
ENH: List runner and matchup info in game threads
ENH: Add locks to prevent multiple threads from updating data cache at the same time
ENH: Logging improvements
REM: Removed table holding game ids for game thread bots -- was not being used and was throwing an error for rescheduled games
INT: Better naming of scheduled tasks
VER: 1.0

### NFL Game Threads
VER: 1.0-alpha
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low priority Unlikely to get attention in the short term
Projects
None yet
Development

No branches or pull requests

1 participant