Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect harmless error when SQL_BACKUP_OPTION=0 #4

Open
odingalt opened this issue Sep 8, 2015 · 0 comments
Open

Incorrect harmless error when SQL_BACKUP_OPTION=0 #4

odingalt opened this issue Sep 8, 2015 · 0 comments

Comments

@odingalt
Copy link

odingalt commented Sep 8, 2015

Using this option set:

LOCAL_BACKUP_OPTION=1
FTP_BACKUP_OPTION=0
SQL_BACKUP_OPTION=0
FILES_BACKUP_OPTION=7

Script will give incorrect error due to this code (it's not really optional, it's happening always):

if [ ! -f $TMP_DIR/backup.incoming/$backup_filename ]; then
echo "Daily backup failed! Please check for missing files." | mail -s "$EMAIL_SUBJECT_TAG Backup Failed" $MAIL
fi

One possible fix is to only check for back-up file name when SQL backup option is set to non-zero? We are using script for CouchDB backup so we used this for temporary fix:

if [ ! $PERFORM_SQL_BACKUP -eq 0 ]; then
if [ ! -f $TMP_DIR/backup.incoming/$backup_filename ]; then
echo "Daily backup failed! Please check for missing files." | mail -s "$EMAIL_SUBJECT_TAG Backup Failed" $MAIL
fi
fi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant