Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't delete old files #5

Open
odingalt opened this issue Sep 8, 2015 · 3 comments
Open

Doesn't delete old files #5

odingalt opened this issue Sep 8, 2015 · 3 comments

Comments

@odingalt
Copy link

odingalt commented Sep 8, 2015

This section of code is incorrect

delete old files

find $TMP_DIR/ -maxdepth 1 -mtime +$RETENTION_DAY_LOOKUP -name "$BACKUP_TYPE" -exec rm -rv {} ;
find $TMP_DIR/.ftp_cache/ -maxdepth 1 -mtime +$RETENTION_DAY_LOOKUP -name "$BACKUP_TYPE" -exec rm -rv {} ;

@odingalt
Copy link
Author

odingalt commented Sep 8, 2015

This means that old backups don't ever get deleted and hard drive will eventually fill. (Remember, last week's backups were stored at $CURRENT_DIR, not $TMP_DIR)

@clickwir
Copy link

clickwir commented Oct 7, 2015

While the find commands here don't look at the right location, the backup was not stored in $CURRENT_DIR.

Section #[Pre]form Files Backup has this:
cd $TARGET_DIR
tar -chJf $TMP_DIR/backup.incoming/$backup_filename $BACKUP_DIR

I'm using xz instead but either way there's no $CURRENT_DIR there.

@todiadiyatmo
Copy link
Owner

@odingalt and @clickwir okay thanks for the info, let me investigate this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants