Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support single page sharing #216

Closed
5 of 8 tasks
tzhangchi opened this issue Feb 14, 2023 · 3 comments
Closed
5 of 8 tasks

Support single page sharing #216

tzhangchi opened this issue Feb 14, 2023 · 3 comments
Assignees
Labels
feat New feature or request story Features perceivable by end-users
Milestone

Comments

@tzhangchi
Copy link
Contributor

tzhangchi commented Feb 14, 2023

Stage1

  1. feat mod:base
    darkskygit

Stage2

  1. feat mod:base mod:libs
    darkskygit
  2. feat mod:base
    darkskygit
  3. feat mod:libs
    darkskygit
  4. feat mod:base mod:libs
    darkskygit

Stage3

  1. feat mod:base
  2. feat mod:storage mod:sync
  3. feat mod:base mod:sync
@JasperStardream
Copy link
Contributor

Why do we need to support SubDoc?

  • When opening a page, we only need to load the page data instead of the entire workspace data, which can improve performance.
  • Support for permission control and sharing through fine-grained data control.

What work does this require us to do?

  • First, upgrade the yrs version, the latest yrs version supports the sub-doc feature.
  • Modify the yrs websocket communication protocol to support sub-doc message distribution.
  • Modify existing server and client code to support the new data structure.
  • Upgrade existing user data to the new data structure.

@darkskygit
Copy link
Member

I prefer to track and move the issue in octobase.

@darkskygit darkskygit transferred this issue from toeverything/AFFiNE Feb 25, 2023
@darkskygit darkskygit added the feat New feature or request label Feb 25, 2023
@doodlewind doodlewind added this to the Alpha Kreta Ayer milestone Mar 14, 2023
@doodlewind doodlewind changed the title Support SubDoc editing and sharing Support sub-doc based single page sharing Mar 14, 2023
@doodlewind doodlewind added the story Features perceivable by end-users label Mar 14, 2023
@darkskygit darkskygit moved this from 📋 Planned to 🏗 In Progress in AFFiNE Project Mar 15, 2023
@doodlewind doodlewind changed the title Support sub-doc based single page sharing Support single page sharing Mar 28, 2023
@doodlewind doodlewind moved this from 🏗 In Progress to 📋 Planned in AFFiNE Project Apr 24, 2023
@xell xell moved this from 📋 Planned to 🚪 Blocked in AFFiNE Project May 17, 2023
@xell xell moved this from 🚪 Blocked to 📋 Planned in AFFiNE Project Aug 28, 2023
@JimmFly
Copy link
Member

JimmFly commented Sep 25, 2023

This issue is outdated and will be closed now

@JimmFly JimmFly closed this as not planned Won't fix, can't repro, duplicate, stale Sep 25, 2023
@github-project-automation github-project-automation bot moved this from 📋 Planned to ✅ Done in AFFiNE Project Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request story Features perceivable by end-users
Projects
Archived in project
Development

No branches or pull requests

7 participants