Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Architecture optimization for AFFiNE cloud #376

Open
1 task done
JasperStardream opened this issue Mar 13, 2023 · 2 comments
Open
1 task done

Architecture optimization for AFFiNE cloud #376

JasperStardream opened this issue Mar 13, 2023 · 2 comments
Labels
feat New feature or request

Comments

@JasperStardream
Copy link
Contributor

JasperStardream commented Mar 13, 2023

Our team has identified several areas that need to be optimized to improve code stability. We plan to implement the following changes:

Improve code readability

  1. zuoxiaodong0815
  • Improve error handling AFFiNE#1772
  • Server-side transaction mechanism: The transaction mechanism will help us avoid data inconsistency and ensure that all requests are processed reliably and consistently.
  • Generate a unique ID for every request AFFiNE#1585
  • Ensure the idempotency of API requests: We will ensure that API requests are idempotent, meaning that multiple requests do not have unexpected effects. This will help us avoid data inconsistency and ensure that our system remains stable.
  • Improve system security: Enhance user permissions, and check for issues such as unauthorized access.
  • check permissions of blob API

These optimizations will help us create a more stable and efficient system, improving code stability and enhancing the user experience.

@JasperStardream JasperStardream self-assigned this Mar 13, 2023
@doodlewind doodlewind changed the title Affine-cloud code adjustment Architecture optimization for AFFiNE cloud Mar 14, 2023
@thorseraq thorseraq assigned thorseraq and unassigned thorseraq Mar 14, 2023
@JasperStardream
Copy link
Contributor Author

Found an issue, the token nonce should not be constant, it's very dangerous to do so.

@JasperStardream JasperStardream transferred this issue from toeverything/AFFiNE Apr 12, 2023
@JasperStardream JasperStardream added this to the Alpha Kreta Ayer milestone Apr 12, 2023
@JasperStardream JasperStardream added the feat New feature or request label Apr 12, 2023
@JasperStardream
Copy link
Contributor Author

The issue of API idempotence is mainly related to the following three APIs:
/api/workspace POST
/api/workspace/:id DELETE
/workspace/:id/blob. PUT

@tzhangchi tzhangchi moved this from 🏗 In Progress to 📋 Planned in AFFiNE Project Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants