This repository has been archived by the owner on Feb 13, 2024. It is now read-only.
[WIP] set duration as negative starttime when receiving an update for a running time entry #4839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📒 Description
There used to be a convention that the duration for a running time entry is equal to negative start time. This convention was heavily used by our desktop app logic.
Nowadays clients and the server do not have to respect this convention and are only caring that the running time entry duration is negative or the stop time is
null.An easy fix to the issue is to enforce this convention locally - make sure any external updates
🕶️ Types of changes
🤯 List of changes
set duration as negative starttime when receiving an update for a running time entry
👫 Relationships
Closes #4835
🔎 Review hints
Test case described in #4835.
Also test various updates of start time, stop time, and duration - on desktop client, on other clients + synced into desktop, re-login and change the duration while the user is logged out, etc.
Needs to be tested on Windows and macOS.
The builds can be taken from the GH Actions artifacts.