Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can transfer max amount after many blocks have been mined? #1

Open
shingonu opened this issue May 18, 2020 · 2 comments
Open

Can transfer max amount after many blocks have been mined? #1

shingonu opened this issue May 18, 2020 · 2 comments
Labels
question Further information is requested todo

Comments

@shingonu
Copy link

expected revert scenario:

  1. mint user's token amount
  2. (after many blocks have been mined) approve users's token -> factor is increased
  3. transfer user's max amount to other account (revert?)

I think we need to make test code about that and make logging about coinage.balanceOf(user) for each steps.

@shingonu shingonu added question Further information is requested todo labels May 18, 2020
@shingonu
Copy link
Author

shingonu commented May 18, 2020

uint256 rbAmount = _toRAYBased(amount);

I think we should delete above code in _transfer and _approve function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested todo
Projects
None yet
Development

No branches or pull requests

1 participant