Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use parse_float-facilities from num-parse when available #143

Open
phorward opened this issue Oct 2, 2024 · 0 comments
Open

Use parse_float-facilities from num-parse when available #143

phorward opened this issue Oct 2, 2024 · 0 comments
Labels
bugfix feature New feature or request help wanted Extra attention is needed
Milestone

Comments

@phorward
Copy link
Member

phorward commented Oct 2, 2024

Tokay uses the num-parse-crate to parse integers.

But there is also a pull request available which should add support to parse floating point numbers effectively using the same approach as parse_int.

Unfortunately, the pull request is stuck with a bug regarding precision, which is not equal to Rust's own compiler's implementation, but it should be equal as far as possible.

It would be nice to integrate num-parses parse_float into the Float-builtin token, which can directly read from a Reader.

@phorward phorward added feature New feature or request help wanted Extra attention is needed bugfix labels Oct 2, 2024
@phorward phorward pinned this issue Oct 2, 2024
@phorward phorward modified the milestones: Tokay v0.6, v0.7 Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix feature New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant