Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open Result shadows some identifiers with result 1.5 on OCaml 4.08+ #12

Open
aantron opened this issue Feb 27, 2020 · 4 comments
Open

Comments

@aantron
Copy link

aantron commented Feb 27, 2020

Namely, this:

open Result

result 1.5 includes Stdlib.Result on 4.08+, which introduces many new identifiers.

The code needs to be changed the same way, whether adapting to result 1.5, or requiring OCaml 4.03+ and dropping result as a dependency, because, either way, on 4.08+, the new identifiers are brought into scope by the open.

@haesbaert
Copy link

Would be nice to cut a release.
Just removing "Line 4: open Result" is enough to compile on 4.10, and it might be worth just requiring 4.03+ and dropping result as mentioned.

@tokenrove
Copy link
Owner

Are either of you interested in maintaining this library? (and its peers, tsdl-ttf and tsdl-mixer) I'm going to do some updates shortly, but I'd be happy to turn over maintenance to someone else with a more active interest in it.

@haesbaert
Copy link

I have very little time so I wouldn't be able to commit to it :/

@sanette
Copy link

sanette commented Sep 17, 2021

solved in the new repo https://github.com/sanette/tsdl-image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants