Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't apply styles to library components but to single newly created elements #1918

Closed
last-skywalker opened this issue May 24, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@last-skywalker
Copy link

last-skywalker commented May 24, 2023

Describe the bug
I have a existing component library with defined tokens.
I created based on my design tokens 2 sets.
If I click on the components it recognizes the relevant design tokens.
If I activate the second set nothing happens.
If I create a new text element, add a token and then activate the second set it changes but only the values, it is even removing the design token.

To Reproduce
Steps to reproduce the behavior:
no description

Expected behavior
I expect that my components react to the change in sets correctly.

Screenshots or Screencasts
Added video.

Figma file (optional)
Send us the link to a Figma file containing a reproducible example

JSON (optional)
If possible, attach the JSON that leads to this bug.

token_studio_fail_1.mp4
@rbosker
Copy link
Collaborator

rbosker commented Jun 5, 2023

@last-skywalker can you check if you have the Setting 'Update Styles' enabled in the bottom right of the plugin?

@last-skywalker
Copy link
Author

@rbosker it is activated.
If I create everything new it is fine. It is not working with my current design system. But probably because it is in different files and I would need Pro to really update it.

@keeganedwin
Copy link
Collaborator

hey @last-skywalker, from the video it looks like you were trying to theme switch published components that were styled from another library. I think you're comment above also mentions that and if that's the case then you are correct. You would need Pro to updates styled components from published libraries.

@esthercheran esthercheran added the bug Something isn't working label Nov 20, 2023
@keeganedwin
Copy link
Collaborator

@last-skywalker were you able to resolve this issue?

@github-project-automation github-project-automation bot moved this from 📥 Triage to ✅ Done in Tokens Studio for Figma Roadmap Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

No branches or pull requests

4 participants