Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on switch theme --> colors on library components not applied in figma #1939

Closed
tada-seilebri opened this issue Jun 5, 2023 · 5 comments
Closed
Labels

Comments

@tada-seilebri
Copy link

tada-seilebri commented Jun 5, 2023

Describe the bug
when I switch the theme in token studio the colors of Library components don't change.

To Reproduce
Steps to reproduce the behavior:

  1. Use the attached Token Files and you can also use the attached Figma Files
  2. Make sure that the setup is as described
  1. Have a Figma File (MASTER Screen Collection) with local color styles
  2. Publish the Figma File 'MASTER Screen Collection' as Library
  3. Have a 2nd Figma File 'DEV Source WIP' consuming the 'MASTER Screen Collection'
  4. Define in 'DEV Source WIP' components (main-navigation) using the colors from 'MASTER Screen Collection'
  5. Publish 'DEV Source WIP' as a library
  6. In 'MASTER Screen Collection' consume 'DEV Source WIP' as a library and use the component 'main-navigation'
  7. In 'MASTER Screen Collection' create a Figma Branch (e.g. 'Demo')
  8. Go to the new Figma Branch 'Demo' and open the Token Studio for Figma
  1. In Token Studio for Figma activate "Update styles"; switch to another Theme (e.g. KIDS) and press "Apply to document"

Expected behavior
The Libary component 'main-navigation' is shown in the correct colors in Figma.
Same color as shown in Token Studio in inspect mode
image

And the same color showed in Figma in the Selection Colors section
image

Some side note - For local components this seems to work
image
image

Figma file (optional)
Figma Files.zip

JSON (optional)
tokens.zip

@tada-seilebri tada-seilebri changed the title colors not applied in figma on switch theme / colors on library components not applied in figma Jun 5, 2023
@tada-seilebri tada-seilebri changed the title on switch theme / colors on library components not applied in figma on switch theme --> colors on library components not applied in figma Jun 5, 2023
@tada-seilebri
Copy link
Author

Maybe this is a similar / linked issue #1858

@esthercheran esthercheran added the bug Something isn't working label Nov 20, 2023
@keeganedwin
Copy link
Collaborator

Hey @tada-seilebri, were you able to resolve this issue?

@tada-seilebri
Copy link
Author

Hi @esthercheran, my assignment to the project where I found this issue has ended and I don’t have a Figma Token license anymore.

Ask @wavestyle for help if you need someone to retest.

@tada-seilebri
Copy link
Author

And no I was not able to solve the issue.

@SamIam4Hyma
Copy link
Collaborator

@LukeFinch proposing to close as the issue is stale and it will come back up again if it needs to be investigated. If you agree please close.

@github-project-automation github-project-automation bot moved this from 📥 Triage to ✅ Done in Tokens Studio for Figma Roadmap Mar 22, 2024
@tada-seilebri tada-seilebri reopened this Mar 22, 2024
@github-project-automation github-project-automation bot moved this from ✅ Done to 👀 Needs review in Tokens Studio for Figma Roadmap Mar 22, 2024
@tada-seilebri tada-seilebri closed this as not planned Won't fix, can't repro, duplicate, stale Mar 22, 2024
@github-project-automation github-project-automation bot moved this from 👀 Needs review to ✅ Done in Tokens Studio for Figma Roadmap Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

No branches or pull requests

4 participants