Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank composition properties causing the fill property to not be applied to Figma layer #1943

Closed
Tracked by #1217
JohnathanHuggett opened this issue Jun 6, 2023 · 4 comments
Labels
bug Something isn't working token type composition TS legacy token type deprecated TBD

Comments

@JohnathanHuggett
Copy link

Describe the bug
When use composition tokens with blank values the fill property within the composition is not being applied to the Figma layer.

To Reproduce
Steps to reproduce the behavior:

  1. Create a composition token with the properties fill, borderColor, 'borderWidthTop'.
  2. Set the fill to a valid color, and leave the other properties blank.
  3. Assign the composition to a Figma layer
Screen Shot 2023-06-06 at 12 40 49 PM

Expected behavior
I would expect the fill color to be applied to the layer no matter the values of other tokens within the composition.

Work Around
Creating a token with the value set to empty seems to fix the issue.

Screen Shot 2023-06-06 at 12 00 59 PM
@six7
Copy link
Collaborator

six7 commented Jun 10, 2023

Out of interest why do you use empty token values in composition tokens?

@JohnathanHuggett
Copy link
Author

We are utilizing tokens to facilitate designers' comprehension of the component's code-based limitations. Considering the necessity to cater to multiple brands, we aim to provide designers with a means to grasp the range of possibilities on the component level. Consequently, there are instances where modifying aspects such as the border is feasible within the code; however, the specific brand in question may not require that particular attribute.

@esthercheran
Copy link
Collaborator

@JohnathanHuggett would you imagine the json structure to be something similar to typography tokens? The empty properties are not displayed in the json. Or would you imagine that a value like none or null be placed for the empty properties?

@SamIam4Hyma SamIam4Hyma added bug Something isn't working token type composition TS legacy token type deprecated TBD labels Mar 20, 2024
@SamIam4Hyma
Copy link
Collaborator

Closing this issues as its stale, feel free to move the convo to Featurebase as a request (:

@SamIam4Hyma SamIam4Hyma closed this as not planned Won't fix, can't repro, duplicate, stale Nov 19, 2024
@github-project-automation github-project-automation bot moved this from 📥 Triage to ✅ Done in Tokens Studio for Figma Roadmap Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working token type composition TS legacy token type deprecated TBD
Projects
Status: ✅ Done
Development

No branches or pull requests

4 participants