Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to select which themes to export as variables #1974

Closed
Tracked by #2489
XavierVilars opened this issue Jun 22, 2023 · 5 comments · Fixed by #2522
Closed
Tracked by #2489

Allow users to select which themes to export as variables #1974

XavierVilars opened this issue Jun 22, 2023 · 5 comments · Fixed by #2522
Assignees

Comments

@XavierVilars
Copy link

XavierVilars commented Jun 22, 2023

Allow users to select the themes to be created as variables.
Currently all themes present are created as variables on clicking Create Variables

In #2406 we introduce a new flow for creating variables from the Export to Figma option

Image

  • Allow users to select the themes that is to created as variables
  • Only the selected themes groups will be created as Variables collection and the selected themes will be created as modes

This will allow the users to create local variables on different Figma files
#2023 will allow the references of variables from different Figma files to be maintained

Original Issue

**Describe the bug** I have 3 Figma files to manage Core, Semantic and Components tokens/variables. - Core file to manage Core tokens/variables, - Semantic file to manage brands and themes related to them. - Components file to manage and publish the components library and hold tier 3 tokens (without publishing them).

Today if I open my Core file in Figma and then open Token Studio and enabling only Core sets. Then if I click on 'Create Variables' it created variables for all my tokens in TS, not only the one enabled...

Expected behavior
So what I want is to be able to export variables to Figma depending on themes enabled in Token Studio. Not everything, just themes enabled.
And of course to be able to generate cross references through my Figma Files automatically (if my Core tokens are in a Core file and if in my Semantic file have references to tokens in my Core file I want a cross reference file token to be created).

It's important in term of maintenance because I can't imagine doing everything manually each time I add a token in Token Studio.

Cheers.

@XavierVilars
Copy link
Author

XavierVilars commented Jun 22, 2023

Aslo I was thinking if possible to check the "hide from publishing" checkbox when a set of tokens is used as a source. Doing this manually is a real pain in this new variables panel.

@davidmcneroe86
Copy link

+1

@esthercheran
Copy link
Collaborator

@XavierVilars when you say hide from publishing do you want to apply that to whole token sets or themes or both? Would love to capture this in a new issue

@esthercheran
Copy link
Collaborator

We have an issue for Hide from publishing in #2300 for individual tokens and #2186 for token groups. But was wondering if you have a different use case

@XavierVilars
Copy link
Author

XavierVilars commented Dec 15, 2023

Hello @esthercheran sorry for the delay I was sick. Yes it could be both token set or theme. And also all token marked as "Source" in a theme.
My main concern when I wrote this issue was to be able to create my differents variables library (in different Figma file) corresponding to my actual headless design system tiers.
So if you give the possibility to sync token in variables in different files then it will fullfill my need.

@LukeFinch LukeFinch changed the title All variables of all themes and group of themes are exported even if not enabled in Token Sudio and cross reference are lost. Allow users to select which themes to export as variables Feb 2, 2024
@LukeFinch LukeFinch moved this from 📤 Ready for dev to ⛔ Blocked in Tokens Studio for Figma Roadmap Feb 2, 2024
@LukeFinch LukeFinch moved this from ⛔ Blocked / Impeded to 📤 Ready for dev in Tokens Studio for Figma Roadmap Feb 15, 2024
@robinhoodie0823 robinhoodie0823 moved this from 📤 Ready for dev to 🕜 In Progress in Tokens Studio for Figma Roadmap Feb 29, 2024
@robinhoodie0823 robinhoodie0823 self-assigned this Feb 29, 2024
@robinhoodie0823 robinhoodie0823 moved this from 🕜 In Progress to 👀 Needs review in Tokens Studio for Figma Roadmap Feb 29, 2024
@github-project-automation github-project-automation bot moved this from 👀 Needs review to ✅ Done in Tokens Studio for Figma Roadmap Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

5 participants