Errors and UI Break on Clicking Settings

[keeganedwin]

Describe the bug
Clicking on certain settings options triggers errors and leads to a complete UI break.

From @SorsOps after reading the user's crash reports from their session ID:

• The issue seems to be caused by the use of spread on properties in React.
• There is a React hook that is being broken and called conditionally, contributing to the problem.

Not easily reproduced
Steps to reproduce the behavior:

1. Navigate to the Settings page
2. Click on certain settings options

Expected behavior
The settings should open without any errors, and the UI should remain functional.

[six7]

@keeganedwin can you add more reproduction steps? Not able to reproduce.

[keeganedwin]

@six7 yea it's tough, even the user wasn't sure what he exactly clicked on that caused this... I don't know if @SorsOps has more information with the crash reports.

[esthercheran]

@keeganedwin can you add the session id of the user?

[keeganedwin]

@esthercheran ID: f42091db199c48e7831f8112100a9c12

Adding user's console log screenshots:

[keeganedwin]

Another similar one: 2486ca8852bb4e9d91e8c7414237e94b
Bug Recording

[esthercheran]

@SorsOps can you add more details on what you found?

[SorsOps]

Looks like the recording got lost off of sentry, but I took a look at the new one. I can't see the exact trigger, but I did look through all the UI components around the Token Listing. Nothing jumped out at me as a conditional react hook, unless one of the hooks uses another hook internally conditionally

[rbosker]

@keeganedwin check if this is maybe already solved by another fix.

[SamIam4Hyma]

@keeganedwin another one to check on pretty please!

[SamIam4Hyma]

@LukeFinch proposing we archive as its stale and the convo has gone cold. if you agree please close, if you think it needs ot be fixed please add the right label (bug) and remove archive.

[SamIam4Hyma]

closing as it can't be reproduced