Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing a colour token to include a modifier doesn't update the figma variable on export (as Sets) #3209

Open
liamco opened this issue Nov 26, 2024 · 2 comments

Comments

@liamco
Copy link

liamco commented Nov 26, 2024

Describe the bug
We have colour tokens in a project which are exported to Figma Variables. There are no colour modifers on these tokens, so in Figma Variables they are correctly stored as references.
If we edit the colour token in Token Studio and add a color modifier like lighten, then on exporting to Figma again, the variable does not update.

It sounds there's a similar issue open already which might be related (#3208), however our behaviour is slightly different; You'll notice in our screen cap attached that we can remove a modifier from a token, export, and the Figma variable correctly reverts from a hex value to a reference. Our bug is only present when trying to change a Figma variable from a reference to a hex value.

To Reproduce
Steps to reproduce the behavior:

  1. Create a colour token which references another colour
  2. Export to Figma variables
  3. In Token Studio, edit the token to have a modifier on top of the reference
  4. Attempt to export again. The Figma variable will not change to a hex value and will remain a reference as before.

Expected behavior
Adding a modifier to an existing token should correctly update any associated Figma variables on export.

Screenshots or Screencasts
https://sharing.clickup.com/clip/p/t6659367/fd49455e-ede0-4d1e-b52c-5438698e6065/screen-recording-2024-11-26-16%3A24.webm

Figma file / JSON file
We can provide these if needed, although would prefer not to do so publicly; Let me know.

@rbosker
Copy link
Collaborator

rbosker commented Dec 2, 2024

@liamco This indeed seems to be a bug. I don't think this is directly related to the linked issue (this one is when exporting as Sets, while the other is an issue with Exporting with Themes). If you use the export with Themes, the variable does update when you add a modifier later on.

@rbosker rbosker changed the title Editing a colour token to include a modifier doesn't update the figma variable on export Editing a colour token to include a modifier doesn't update the figma variable on export (as Sets) Dec 2, 2024
@liamco
Copy link
Author

liamco commented Dec 9, 2024

@rbosker cheers for the reply. When we first spotted the bug on a live project we were exporting using themes. The screencap I sent was of a quick replication case I whipped up hence why it used sets. Sorry if that was misleading. Would you like me to get a better video of us replicating the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 📥 Triage
Development

No branches or pull requests

3 participants