You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
But which of IoSlice and IoSliceMut should replace libc::iovec? Or should both be supported? The more obvious answer to me is only accepting IoSliceMut since if we want to share these buffers with the kernel we probably can't easily make the guarantee that there are no shared references to the underlying slice. On the other hand, this is marked unsafe so it could be okay?
Simply doing that and converting the iovec into IoSliceMut in the test_tcp_zero_copy_send_fixed test (plus the test that I wrote in #278) passes. Though to be clear those are the only tests that test register_buffers.
IoSlice
andIoSliceMut
are in the standard library. See: nix-rust/nix#1643 for some background.io-uring's
Submitter::register_buffers
uses alibc::iovec
.I propose to adopt the standard library type in order to increase API compatibility.
The text was updated successfully, but these errors were encountered: