Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating to version 1.2.3 causes significant performance issues #45

Open
Snailedlt opened this issue Sep 10, 2024 · 2 comments
Open

Updating to version 1.2.3 causes significant performance issues #45

Snailedlt opened this issue Sep 10, 2024 · 2 comments

Comments

@Snailedlt
Copy link

Recently a dependabot updating fastapi-analytics from 1.2.2 to 1.2.3 caused the API deployment to fail due to stability issues. The performance was also significantly slower than before for no apparant reason I could find.

Before:

image

After:

image

You'll find some more info in the dependabot PR here: Snailedlt/Markdown-Videos#563

On a sidenote:
Having release notes and a changelog would help in knowing which change(s) cause issues to occur. I'll make a separate issue about that though.

@tom-draper
Copy link
Owner

Ah interesting! The main difference with 1.2.3 is debug logging with the python logging module. Do you have your logging level set to debug with something like logging.basicConfig(level=logging.DEBUG)? Documentation pointed to a minimal impact on performance if the logging level is set below. I'll run some benchmarks and confirm the cause. Thanks again.

@Snailedlt
Copy link
Author

Interesting.
I haven't touched logging, so I have no idea what it's set to.
Couldn't find anything in the source code when searching for logging

This is the only setup for fastapi-analytics afaik: https://github.com/Snailedlt/Markdown-Videos/blob/98013ff4e8f12cf95a61c9b0ff7cd2495c4c7078/apps/api/main.py#L36-L37

Feel free to check out the source code for more info though. It's all open source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants