Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve dcm.py inheritance #9

Open
1 of 3 tasks
tomaroberts opened this issue Aug 7, 2023 · 0 comments
Open
1 of 3 tasks

Improve dcm.py inheritance #9

tomaroberts opened this issue Aug 7, 2023 · 0 comments

Comments

@tomaroberts
Copy link
Owner

tomaroberts commented Aug 7, 2023 •
edited
Loading

Related to #8 – need to improve class inheritance. Currently, the Dicom class is too MR biased.

TODO:

  • shift the add_module() calls to DicomMRI subclass
  • need to ensure init_study_tags() and init_series_tags() are called after all the other tags in DicomMRI subclass are initialised
  • replicate this structure with DicomCT subclass that calls modules relevant to NEMA CT Image Module Table
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tomaroberts