[#82] CAPS devices improvements and bugfixes (Part 9: MessageBar about unsupported features)

Author: tomas-nestorovic

Main/src/CapsBase.cpp

@@ -516,8 +516,6 @@
 			::SetLastError( ERROR_CANCELLED );
 			return FALSE;
 		}
-		// - warning on unsupported Cylinders
-		WarnOnAndCorrectExceedingCylinders();
 		// - successfully mounted
 		return TRUE;
 	}
@@ -956,14 +954,14 @@
 			return false;
 	}
 
-	void CCapsBase::WarnOnAndCorrectExceedingCylinders(){
-		// if current # of Cylinders exceeds supported limit, shows a pop-up message and corrects the #
-		if (capsImageInfo.maxcylinder>FDD_CYLINDERS_MAX){ // inclusive!
-			TCHAR msg[200];
-			::wsprintf( msg, _T("The image contains %d cylinders, ") _T(APP_ABBREVIATION) _T(" shows just first %d of them."), capsImageInfo.maxcylinder+1, FDD_CYLINDERS_MAX );
-			Utils::Warning(msg);
-			capsImageInfo.maxcylinder=FDD_CYLINDERS_MAX-1; // inclusive!
+	CString CCapsBase::ListUnsupportedFeatures(){
+		// returns a list of all features currently not properly implemented
+		CString list;
+		if (capsImageInfo.maxcylinder>FDD_CYLINDERS_MAX){ // inclusive! - current # of Cylinders exceeds supported limit
+			list.Format( _T("- disk contains %d cylinders, ") _T(APP_ABBREVIATION) _T(" shows just first %d of them\n"), capsImageInfo.maxcylinder+1, FDD_CYLINDERS_MAX );
+			capsImageInfo.maxcylinder=FDD_CYLINDERS_MAX-1; // inclusive! - correct # of Cylinders
 		}
+		return list + __super::ListUnsupportedFeatures();
 	}
 
 	CCapsBase::PInternalTrack CCapsBase::GetModifiedTrackSafe(TCylinder cyl,THead head) const{

Main/src/CapsBase.h

@@ -186,7 +186,6 @@
 
 		virtual TStdWinError UploadFirmware();
 		virtual TStdWinError UploadTrack(TCylinder cyl,THead head,CTrackReader tr) const;
-		void WarnOnAndCorrectExceedingCylinders();
 		PInternalTrack GetInternalTrackSafe(TCylinder cyl,THead head) const;
 		PInternalTrack GetModifiedTrackSafe(TCylinder cyl,THead head) const;
 		bool AnyTrackModified(TCylinder cyl) const;
@@ -220,6 +219,7 @@
 		bool RequiresFormattedTracksVerification() const override sealed;
 		TStdWinError UnformatTrack(TCylinder cyl,THead head) override;
 		TStdWinError MineTrack(TCylinder cyl,THead head) override sealed;
+		CString ListUnsupportedFeatures() override;
 	};
 
 

Main/src/HFE.cpp

@@ -64,6 +64,7 @@
 
 			bool IsValid() const;
 			bool IsVersion3() const;
+			CString ListUnsupportedFeatures() const;
 			TLogTime GetCellTime() const;
 		} header;
 
@@ -126,6 +127,7 @@
 		bool EditSettings(bool initialEditing) override;
 		TStdWinError Reset() override;
 		TStdWinError FormatTrack(TCylinder cyl,THead head,Codec::TType codec,TSector nSectors,PCSectorId bufferId,PCWORD bufferLength,PCFdcStatus bufferFdcStatus,BYTE gap3,BYTE fillerByte,const volatile bool &cancelled) override;
+		CString ListUnsupportedFeatures() override;
 	};
 
 #endif // HFE_H

Main/src/HFE.h

@@ -557,6 +557,23 @@ namespace Medium{
 
 
 
+	CImage::CUnsupportedFeaturesMessageBar::CUnsupportedFeaturesMessageBar()
+		// ctor
+		: CMainWindow::CMessageBar( _T("The image contains <a>features currently not supported</a> by ") APP_ABBREVIATION _T(".") ) {
+	}
+
+	void CImage::CUnsupportedFeaturesMessageBar::HyperlinkClicked(LPCWSTR id) const{
+		Utils::Information(report);
+	}
+
+	void CImage::CUnsupportedFeaturesMessageBar::Show(const CString &report){
+		//
+		if (!( this->report=report ).IsEmpty())
+			__super::Show();
+	}
+
+
+
 
 
 
@@ -609,6 +626,11 @@ namespace Medium{
 		return ERROR_SUCCESS; // always succeeds (but may fail in CDos-derivates)
 	}
 
+	CString CImage::ListUnsupportedFeatures(){
+		// returns a list of all features currently not properly implemented
+		return CString();
+	}
+
 	void CImage::ToggleWriteProtection(){
 		// toggles Image's WriteProtection flag
 		// - cannot toggle if not allowed to write to the Image (e.g. because the Image has been opened from a CD-ROM)

Main/src/Image.cpp

@@ -324,6 +324,14 @@
 			void SetReadOnlyReason(LPCTSTR readOnlyReason);
 		} readOnlyMessageBar; // the reason why WriteProtection can't be removed
 
+		class CUnsupportedFeaturesMessageBar sealed:public CMainWindow::CMessageBar{
+			CString report;
+			void HyperlinkClicked(LPCWSTR id) const override;
+		public:
+			CUnsupportedFeaturesMessageBar();
+			void Show(const CString &report);
+		} unsupportedFeaturesMessageBar;
+
 		class CTrackReaderBase{
 		public:
 			enum TDecoderMethod:BYTE{
@@ -823,6 +831,7 @@
 		virtual TStdWinError MineTrack(TCylinder cyl,THead head);
 		virtual CSectorDataSerializer *CreateSectorDataSerializer(CHexaEditor *pParentHexaEditor)=0;
 		virtual TStdWinError CreateUserInterface(HWND hTdi);
+		virtual CString ListUnsupportedFeatures();
 		void SetRedrawToAllViews(bool redraw) const;
 		bool ReportWriteProtection() const;
 		void ToggleWriteProtection();

Main/src/Image.h

@@ -107,15 +107,15 @@
 		} *pTdi;
 
 		class CMessageBar:protected CStatusBar{
-			static int D; // dimension
-			const WCHAR glyph;
 			HWND hGlyph,hSysLink,hCloseBtn;
 		protected:
+			static int D; // dimension
+			const WCHAR glyph;
+			CString msgHyperlink;
+
 			virtual void HyperlinkClicked(LPCWSTR id) const;
 			LRESULT WindowProc(UINT msg,WPARAM wParam,LPARAM lParam) override;
 		public:
-			CString msgHyperlink;
-
 			CMessageBar(LPCTSTR msgHyperlink,WCHAR webdingsGlyph=L'\xf069');
 			~CMessageBar();
 

Main/src/MainWindow.h

@@ -84,8 +84,6 @@ formatError: ::SetLastError(ERROR_BAD_FORMAT);
 			return FALSE;
 		}
 		header.flags.normalized|=params.corrections.valid&&params.corrections.use;
-		// - warning on unsupported Cylinders
-		WarnOnAndCorrectExceedingCylinders();
 		return TRUE;
 	}
 

Main/src/SCP.cpp

@@ -416,6 +416,8 @@ openImage:	if (image->OnOpenDocument(lpszFileName)){ // if opened successfully .
 		image->SetPathName( lpszFileName, FALSE ); // at this moment, Image became application's active document and the name of its underlying file is shown in MainWindow's caption
 		// - adding file Image into list of Most Recently Used (MRU) documents
 		//nop (added by calling CDocument::SetPathName below)
+		// - reporting about not properly implemented features of the Image
+		image->unsupportedFeaturesMessageBar.Show( image->ListUnsupportedFeatures() );
 		// - determining the DOS
 		CDos::PCProperties dosProps=nullptr;
 		TFormat formatBoot=TFormat::Unknown; // information on Format (# of Cylinders, etc.) obtained from Image's Boot record