Creation of dynamic property TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController::$applicationData is deprecated

[chludwig]

Bug Report

Current Behavior
In the system log there are hundreds off error messages each day:

Core: Exception handler (WEB): Uncaught TYPO3 Exception: #1476107295: PHP Runtime Deprecation Notice: Creation of dynamic property TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController::$applicationData is deprecated in /home/www/production/vendor/tomasnorre/crawler/Classes/Middleware/CrawlerInitialization.php line 60 | TYPO3\CMS\Core\Error\Exception thrown in file /home/www/roduction/vendor/typo3/cms-core/Classes/Error/ErrorHandler.php in line 141. Requested URL: https://domain.de/dbsystel

They are produced by the scheduled crawler.

Expected behavior/output
Crawling shouldn't produce errors.

Steps to reproduce
Configure a crawler as shown above and execute it. (The website was updated from TYPO3 v12.4)

Environment

• Crawler version(s): 12.0.7
• TYPO3 version(s): 13.4.5
• PHP version(s): 8.3.16
• Is your TYPO3 installation set up with Composer (Composer Mode): yes

[github-actions]

Hi there, thank you for taking your time to create your first issue. Please give us a bit of time to review it.

[tomasnorre]

Thanks for your issue, but I cannot reproduce this, without knowing the crawler configuration.

This is only a Scheduler configuration and will look the same on most systems but with different crawler configurations. So I need the concrete configuration to be able to help you further.

[maelstromer]

While upgrade a client TYPO3 system to version 13.4 I have encountered the same issue. The TYPO3 log produces the same TYPO3 Exception that chludwig postig in the OP, for each page in the processing-queue.

I had a look at the CrawlerInitialization class and noticed that it attempts to access the property $GLOBALS['TSFE']->applicationData multiple times, starting at line 60. However, according to "Breaking #102600" in the TYPO3 changelog, this property was removed with TYPO3 v13 (see: https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/13.0/Breaking-102600-TSFE-applicationDataRemoved.html#breaking-102600-tsfe-applicationdata-removed)

This would explain the error message, because it is being interpreted as an attempt to dynamically create the property, due to it no longer being part of $GLOBALS['TSFE'].

When processing the built queue via CLI, no new entries are added to the index and crawler responds with the following:
Unprocessed Items remaining:16 (aa786c059902b47a15869dd96f48767e) 3

This is off a default crawler configuration, using tx_indexsearch_reindex as processing instruction filter and attempting to crawl the whole website.

The way I see it, the CrawlerInitialization class needs to adapted, so that it no longer uses the removed property.

[chludwig]

@tomasnorre Here's my configuration. What has no special settings.

settings.php:

       'crawler' => [
            'cleanUpOldQueueEntries' => '1',
            'cleanUpProcessedAge' => '2',
            'cleanUpScheduledAge' => '7',
            'countInARun' => '100',
            'crawlHiddenPages' => '0',
            'enableTimeslot' => '1',
            'frontendBasePath' => '/',
            'makeDirectRequests' => '0',
            'maxCompileUrls' => '10000',
            'phpBinary' => 'php',
            'phpPath' => '',
            'processDebug' => '0',
            'processLimit' => '1',
            'processMaxRunTime' => '300',
            'processVerbose' => '0',
            'purgeQueueDays' => '14',
            'sleepAfterFinish' => '10',
            'sleepTime' => '1000',
        ],

And here's my crawler configuration

[kraemer-igroup]

Hi @tomasnorre, I am having the same issue and got exactly to the same conclusion as @maelstromer.
To see the error, you maybe have to modify the configuration for [SYS][exceptionalErrors] to 12290. (@chludwig) With 4096 the Deprecation Notice does not lead to a TYPO3 Exception and pages are being crawled.

As solution, maybe those setting could be stored in a custom session, whithout using $GLOBALS['TSFE'] for it.

[tomasnorre]

Thanks for your input. If you have a suggestion I would be happy to review a PR.

[tomasnorre]

I know this is far from working yet, at least the tests.

I would love to get your feedback on the idea on this approach.
#1158

Thanks in advance.