Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated User fields #169

Open
potomak opened this issue Oct 6, 2016 · 4 comments
Open

Remove deprecated User fields #169

potomak opened this issue Oct 6, 2016 · 4 comments

Comments

@potomak
Copy link
Member

potomak commented Oct 6, 2016

Before authorizations embedded documents existed, auth data was stored in the users documents. Active users' data should be up to date, because auth data is updated during session creation.

Let's remove User's deprecated attributes and update finders (#find_by_omniauth).

User attributes to be removed:

  • provider
  • uid
  • token
  • gravatar_id
@morrme
Copy link
Contributor

morrme commented Mar 20, 2017

I have found the attributes mentioned in the app/models/user.rb file. What other file or data work would need to be done to be able to help?

@potomak
Copy link
Member Author

potomak commented Mar 21, 2017

@morrme remove the fields, run the app and test your change.

I'd suggest to add a test for a case some users still don't have authorizations embedded documents.

@morrme
Copy link
Contributor

morrme commented Mar 21, 2017

Do you want the fields removed from existing documents as well ( like User.each { |user| user.unset(:uid) } etc?

@potomak
Copy link
Member Author

potomak commented Mar 21, 2017

Yes, but for that there should be a rake task that I could use against the prod database.

@morrme that would be a delicate task that I should work on, and I guess that is a blocker for this issue.

Let's put this on hold please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants