Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to run dev when file path to Issie repo includes spaces on Windows #166

Open
adidesh20 opened this issue May 18, 2022 · 3 comments
Open

Comments

@adidesh20
Copy link
Contributor

adidesh20 commented May 18, 2022

Describe the bug
When trying to run npm run dev when the directory the Issie repo is in contains spaces, the script fails when trying to start the Electron main. For example, the following path to Issie: 'C:\Some Dir\issie' would spawn the following error: 'C:\Some' is not recognized as an internal or external command, operable program or batch file.

To Reproduce
Steps to reproduce the behavior:

  1. Clone Issie to a directory with spaces in the file path
  2. Try run build.cmd

Desktop (please complete the following information):

  • OS: Windows (have not tested if this is an issue on Mac/Linux)
  • Node v16.15.0

Additional context
Bug has already been reported to Archontis (@apantelopoulos) by email, creating a Github Issue for tracking purposes.

@tomcl
Copy link
Owner

tomcl commented May 19, 2022

Need teh right combo of escapes:

@apantelopoulos

apantelopoulos pushed a commit that referenced this issue May 19, 2022
@apantelopoulos
Copy link
Collaborator

Works now on my windows PC.

Need to check macOS as well to close the issue
@tomcl

@tomcl
Copy link
Owner

tomcl commented May 22, 2022

I have merged your commits into new-build-trimmed and run the macos build.

  • Dev build works fine
  • I get an error on production build (see below) but I suspect this may be because we are using the wrong (e.g. deprecated and now lost) architecture name in the build script.

I suggest @apantelopoulos looks at this part of the new build and redoes the macos builds as follows:

  • we need one working intel 64 bit macos build, preferably to dmg but to zip would probably do.
  • building        target=macOS zip arch=arm64 file=dist/issie-3.0.0-beta.4-arm64-mac.zip
  • building        target=DMG arch=arm64 file=dist/issie-3.0.0-beta.4-arm64.dmg
  • building block map  blockMapFile=dist/issie-3.0.0-beta.4.dmg.blockmap
  • building block map  blockMapFile=dist/issie-3.0.0-beta.4-arm64.dmg.blockmap
  • building block map  blockMapFile=dist/issie-3.0.0-beta.4-arm64-mac.zip.blockmap
  • building block map  blockMapFile=dist/issie-3.0.0-beta.4-mac.zip.blockmap
afterSign hook triggered {
  outDir: '/Users/tomcl/Documents/GitHub/issie/dist',
  artifactPaths: [
    '/Users/tomcl/Documents/GitHub/issie/dist/issie-3.0.0-beta.4.dmg.blockmap',
    '/Users/tomcl/Documents/GitHub/issie/dist/issie-3.0.0-beta.4.dmg',
    '/Users/tomcl/Documents/GitHub/issie/dist/issie-3.0.0-beta.4-arm64.dmg.blockmap',
    '/Users/tomcl/Documents/GitHub/issie/dist/issie-3.0.0-beta.4-arm64.dmg',
    '/Users/tomcl/Documents/GitHub/issie/dist/issie-3.0.0-beta.4-arm64-mac.zip.blockmap',
    '/Users/tomcl/Documents/GitHub/issie/dist/issie-3.0.0-beta.4-arm64-mac.zip',
    '/Users/tomcl/Documents/GitHub/issie/dist/issie-3.0.0-beta.4-mac.zip.blockmap',
    '/Users/tomcl/Documents/GitHub/issie/dist/issie-3.0.0-beta.4-mac.zip'
  ],
  platformToTargets: Map(1) {
    Platform {
      name: 'mac',
      buildConfigurationKey: 'mac',
      nodeName: 'darwin'
    } => Map(2) { 'zip' => [ArchiveTarget], 'dmg' => [DmgTarget] }
  },
  configuration: {
    directories: { output: 'dist', buildResources: 'build' },
    appId: 'ISSIE',
    files: [ [Object] ],
    extraFiles: [ [Object] ],
    appx: { applicationId: 'ISSIE' },
    win: { icon: 'public/icon.ico', target: 'zip' },
    linux: { icon: 'public/icon.png', target: 'zip' },
    mac: { icon: 'public/icons/icon.icns', target: [Object] },
    afterAllArtifactBuild: 'scripts/afterSignHook.js',
    electronVersion: '17.4.4'
  }
}
appPath not found /Users/tomcl/Documents/GitHub/issie/dist/undefined-darwin.dmg
Toms-MacBook-Air:issie tomcl$ 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants