Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get_company_updates and get_profile_updates: optimize use of max_results #227

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

get_company_updates and get_profile_updates: optimize use of max_results #227

wants to merge 1 commit into from

Conversation

rbignon
Copy link

@rbignon rbignon commented Jun 26, 2022

  1. do not set [] as a default parameter, as it is a global list and if the method is called twice, previous results will be included
  2. extend results before checking if results limit is reached, it prevents useless API calls
  3. return only required results

@rbignon
get_company_updates and get_profile_updates: optimize use of max_results
87084ff 
1. do not set [] as a default parameter, as it is a global list and if
   the method is called twice, previous results will be included
2. extend results *before* checking if results limit is reached, it
   prevents useless API calls
3. return only required results
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rbignon