Optional plays nice with Hashie::Mash. Should it play nice with ActionController::Parameters and OpenStruct too? #6
Comments
|
Hi @olistik can you explain to me why are you using such examples? in my thoughts the valid examples should be: require 'monads'
require 'ostruct'
require 'action_pack'
require 'rack/test'
require 'action_controller'
params = {
foo: {
bar: 42
}
}
rails_params = ActionController::Parameters.new(params)
ostruct_params = OpenStruct.new(params)
ostruct_rails_params = OpenStruct.new(rails_params)
Monads::Optional.new(ostruct_params).foo.bar
# NoMethodError: undefined method `bar' for {:bar=>42}:Hash
# ... but
Monads::Optional.new(ostruct_params).foo[:bar]
# => #<struct Monads::Optional value=42>
Monads::Optional.new(ostruct_rails_params).foo.bar
# NoMethodError: undefined method `bar' for {"bar"=>42}:ActionController::Parameters
# ... but
Monads::Optional.new(ostruct_rails_params).foo[:bar]
Monads::Optional.new(ostruct_params).foo.bar.value
# NoMethodError: undefined method `bar' for {:bar=>42}:Hash
# ... but
Monads::Optional.new(ostruct_params).foo[:bar].value
# => 42
Monads::Optional.new(ostruct_rails_params).foo.bar.value
# NoMethodError: undefined method `bar' for {"bar"=>42}:ActionController::Parameters
# ... but
Monads::Optional.new(ostruct_rails_params).foo[:bar].value
# => 42Or I misunderstand something ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I was experimenting the use of
Monads::Optionalwith chains of calls that imply hash access, such as when dealing with Rails parameters:Initially I thought that wrapping an
OpenStructaround aHashwould've been a good fit forMonads::Optionalbut then I discovered that it doesn't work.Here's a list of tests that I've run:
It looks like that the only viable solution is to wrap
paramsinto aHashie::Mashand then pass it toMonads::Optional.Would you like/expect to have an implementation that supports
OpenStructandActionController::Parameters?The text was updated successfully, but these errors were encountered: