Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ashwanthkumar/gocd-build-github-pull-requests #27

Open
marandalucas opened this issue Jun 27, 2017 · 2 comments
Open

Implement ashwanthkumar/gocd-build-github-pull-requests #27

marandalucas opened this issue Jun 27, 2017 · 2 comments

Comments

@marandalucas
Copy link

We would like to integrate the plugin ashwanthkumar/gocd-build-github-pull-requests..

Currently we are doing with manual templates, I would like to be able to add by yaml code, thank you very much for your work

@tomzo
Copy link
Owner

tomzo commented Jun 27, 2017

Hi @marandalucas

It is already possible to make references to pluggable materials. The limitation is that you still need to keep scms element in XML.

For example, when your github PR plugin is configured in XML with

<scms>
<scm id="7e0072f2-dd30-4cdc-b618-336be0e5e14d" name="Portal-pull-request">
<pluginConfiguration id="github.pr" version="1" />
<configuration>
<property>
<key>url</key>
<value>mygit_repo</value>
</property>
<property>
<key>username</key>
<value>blablabla</value>
</property>
<property>
<key>password</key>
<encryptedValue>gjhgjhghgjhgjhghjgj</encryptedValue>
</property>
</configuration>
</scm>
</scms>

You can use that in yaml with

...
materials:
  myPluggableGit:
    scm: 7e0072f2-dd30-4cdc-b618-336be0e5e14d
...

But if that is too much a limitation and you want to implement storing scms in yaml, that is also possible. Although 99% of work will be on server side in https://github.com/gocd/gocd . I can help with that.
Let me know if above config is what you needed, I am not sure if that actually works. But I know a few people are using github PR plugin, you search the chat

@tomzo
Copy link
Owner

tomzo commented Sep 13, 2020

For reference, the server side issue for building feature branches gocd/gocd#6123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants