Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatch in ADNL UDP docs #624

Open
jacobs100500 opened this issue Jun 12, 2024 · 0 comments
Open

Mismatch in ADNL UDP docs #624

jacobs100500 opened this issue Jun 12, 2024 · 0 comments

Comments

@jacobs100500
Copy link

Is your feature request related to a problem? Please describe.

This doc have text:

It remains to determine which key to use for what, we can do this by comparing the id of our public channel key with the id of the public key of the server channel, converting them to a numerical form - uint256.

And this doc:

Осталось определить какой ключ для чего использовать, мы можем это сделать, сравнив айди нашего публичного ключа канала с айди публичного ключа канала сервера, переведя их в числовой вид - uint256.

It's a mismatch because we need to compare the ID of our key and the ID of the server key. Needs to compare connection keys, NOT channel keys.

Describe the solution you'd like

Proof in code:
https://github.com/ton-blockchain/ton/blob/master/adnl/adnl-channel.cpp#L47
https://github.com/yungwine/pytoniq-core/blob/master/pytoniq_core/crypto/ciphers.py#L60

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant