Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Datatype to DataType #234

Open
ethe opened this issue Nov 21, 2024 · 3 comments
Open

Rename Datatype to DataType #234

ethe opened this issue Nov 21, 2024 · 3 comments
Assignees
@ethe
Labels
enhancement New feature or request good first issue Good for newcomers XS - Tiny Fixing typos, adding or modifying comments, minor configuration changes.

Comments

@ethe
Copy link
Member

ethe commented Nov 21, 2024

What is the current?

It names tonbo::record::Datatype

What will it become?

tonbo::record::DataType

What are the benefits?

Make it align human intuition

Are there any alternatives?

No

Does it have a reference?

https://docs.rs/arrow/latest/arrow/datatypes/enum.DataType.html
@ethe ethe added the enhancement New feature or request label Nov 21, 2024
@linear Linear
Copy link

linear bot commented Nov 21, 2024

TON-93 Rename `Datatype` to `Datatype`

@ethe ethe self-assigned this Nov 21, 2024
@ethe ethe added XS - Tiny Fixing typos, adding or modifying comments, minor configuration changes. good first issue Good for newcomers labels Nov 21, 2024
@sollhui
Copy link
Contributor

sollhui commented Nov 22, 2024

typo: Rename Datatype to Datatype to Rename Datatype to DataType?

@ethe ethe changed the title Rename Datatype to Datatype Rename Datatype to DataType Nov 22, 2024
@ethe
Copy link
Member Author

ethe commented Nov 22, 2024

Yes you're right, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ethe ethe

Labels
enhancement New feature or request good first issue Good for newcomers XS - Tiny Fixing typos, adding or modifying comments, minor configuration changes.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ethe @sollhui