Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Potential Bug] Firefox malfrom library post request breaking folder path #171

Open
inonoob opened this issue Nov 8, 2024 · 8 comments
Open

Comments

@inonoob
Copy link

inonoob commented Nov 8, 2024

Dear all,

Issue:

When trying to perform bulk conversion of ogg files into TAF file(s), the system is rejecting it with "Encoding failed". In the docker container log the following is showing:

 `ERROR|handler_api.c:1928:handleApiEncodeFile| target missing!`

But when amount of files selected is reduce to 10 only then the system start processing all the ogg files and create ONE total file

EDIT: that is only valid for a certain type of folder name.

it seems the folder naming pattern is source of multiple issues in the file manager.

Setup:

Browser Firefox 130.0.1 (64-bit)
Browser add-on U-block & no-script disable for Teddycloud
OS: Linux Ubuntu 22
[TeddyCloud vX.X.X (302e7e1) - 2024-11-05 20:16:52 +0000 ubuntu linux-x86_64(64)]
Running on docker in a VM on proxmox

Expected behavior:

Encode amount of file not limited to 10

How to recreate:

Case1: NOT WORKING

  • Create folder with name [paw patrol]
  • Go into folder [paw patrol]
  • Create a folder with name [Paw patrol AffenNaut]
  • go into [Paw patrol AffenNaut]
  • Upload more than 10 ogg files e.g Paw patrol CD AffenNaut ogg - in total 14 tracks in ogg format
  • Select all with the "Select all tickbox"
  • Select convert to TAF button
  • Select as output folder [Paw patrol AffenNaut]
  • Give the filename "test"
  • Click encode
  • Get error code as descried in "Issues"

Case2: WORKING

  • Create folder with name [paw patrol]
  • Go into folder [paw patrol]
  • Create folder [test -]
  • Go into [test -]
  • Upload more than 10 ogg files e.g Paw patrol CD AffenNaut ogg - in total 14 tracks in ogg format
  • Select all with the "Select all tickbox"
  • Select convert to TAF button
  • Select as output folder [test -]
  • Give the filename "test"
  • Click encode
  • All is working and file in [test -]

Case3: Working with 10 files but new Bug shows up.

  • Create folder with name [paw patrol]
  • Go into folder [paw patrol]
  • Create a folder with name [Paw patrol - Affen-Naut]
  • go into [Paw patrol - Affen-Naut]
  • Upload more than 10 ogg files e.g Paw patrol CD AffenNaut ogg - in total 14 tracks in ogg format
  • Select all with the "Select all tickbox"
  • Select only 10 ogg files !
  • Select convert to TAF button
  • Select as output folder [Paw patrol - Affen-Naut]
  • Give the filename [Paw patrol - Affen-Naut]
  • Click encode
  • TAF file won't be in [Paw patrol - Affen-Naut] but one high folder hierarchy higher and will ignore the given name "test" and name the file to "Paw patrol - Af"

Question: is it possible to have the title convert in bulk but keep the naming convention and not to create one file only. As then the skipping function won't work or do I need to convert each file one by one ?
I might understood, TAF supports already skipping because the toniebox sees them as different tracks and the TAF file type is limited to 99 tracks per TAF file.

toniebox-reverse-engineering/teddycloud#89

Is that Correct ?

@inonoob inonoob changed the title [Potential Bug] TAF bulk converting limited to 10 tracks [Potential Bug] TAF bulk converting limited to 10 tracks - Potential folder naming conventation issue Nov 8, 2024
@inonoob
Copy link
Author

inonoob commented Nov 8, 2024

I'm getting closer to understand the issue. It really seems to be a problem with the length of the path and directories. But the bug is still very strange as it seems to behave different depending on the naming for the folder.

@inonoob
Copy link
Author

inonoob commented Nov 8, 2024

If you try to encode more than 10 tracks from ogg to TAF and you keep the name of the folder short, the TAF encoder will ignore the naming of the TAF file and place the file one hierarchy higher. But if you select only 10 tracks then the TAF file will be place with the correct name in the selected folder.
If the folder name is very long and more than 10 tracks are selected then the system is not even trying to encode the file in TAF.

@henryk86
Copy link
Collaborator

henryk86 commented Nov 8, 2024

i would avoid spaces in folders

@henryk86
Copy link
Collaborator

henryk86 commented Nov 8, 2024

what are the docker logs saying?

@henryk86
Copy link
Collaborator

henryk86 commented Nov 8, 2024

and please use browser develop mode and have a look on the network requests. are they containing the expected source files and targetfile?

image

@inonoob
Copy link
Author

inonoob commented Nov 9, 2024

Hey,

request which is not working:

Request: 

source=%2Fpaw%20patrol%2FPawPatrolFolder%2F01%20-%20Der%20Gestohlene%20Honig%201.ogg
&source=%2Fpaw%20patrol%2FPawPatrolFolder%2F02%20-%20Der%20Gestohlene%20Honig%202.ogg
&source=%2Fpaw%20patrol%2FPawPatrolFolder%2F03%20-%20Der%20Gestohlene%20Honig%203.ogg
&source=%2Fpaw%20patrol%2FPawPatrolFolder%2F04%20-%20Der%20Gestohlene%20Honig%204.ogg
&source=%2Fpaw%20patrol%2FPawPatrolFolder%2F05%20-%20Die%20Handtaschendiebe%201.ogg
&source=%2Fpaw%20patrol%2FPawPatrolFolder%2F06%20-%20Die%20Handtaschendiebe%202.ogg
&source=%2Fpaw%20patrol%2FPawPatrolFolder%2F07%20-%20Die%20Handtaschendiebe%203.ogg
&source=%2Fpaw%20patrol%2FPawPatrolFolder%2F08%20-%20Die%20Bergtour%201.ogg
&source=%2Fpaw%20patrol%2FPawPatrolFolder%2F09%20-%20Die%20Bergtour%202.ogg
&source=%2Fpaw%20patrol%2FPawPatrolFolder%2F10%20-%20Die%20Bergtour%203.ogg
&source=%2Fpaw%20patrol%2FPawPatrolFolder%2F11%20-%20Die%20Bergtour%204.ogg
&source=%2Fpaw%20patrol%2FPawPatrolFolder%2F12%20-%20Der%20Affen-Naut%201.ogg
&source=%2Fpaw%20patrol%2FPawPatrolFolder%2F13%20-%20Der%20Affen-Naut%202.ogg
&source=%2Fpaw%20patrol%2FPawPatrolFolder%2F14%20-%20Der%20Affen-Naut%203.ogg
&target=%2FPawPatroltest.taf

Response: 
Error 400

The request is badly formed

Working request but places the file at the root in library and ignore the target path

Request: 

source=%2Fpaw%20patrol%2FPawPatrolFolder%2F01%20-%20Der%20Gestohlene%20Honig%201.ogg
&source=%2Fpaw%20patrol%2FPawPatrolFolder%2F02%20-%20Der%20Gestohlene%20Honig%202.ogg
&source=%2Fpaw%20patrol%2FPawPatrolFolder%2F03%20-%20Der%20Gestohlene%20Honig%203.ogg
&source=%2Fpaw%20patrol%2FPawPatrolFolder%2F04%20-%20Der%20Gestohlene%20Honig%204.ogg
&source=%2Fpaw%20patrol%2FPawPatrolFolder%2F05%20-%20Die%20Handtaschendiebe%201.ogg
&source=%2Fpaw%20patrol%2FPawPatrolFolder%2F06%20-%20Die%20Handtaschendiebe%202.ogg
&source=%2Fpaw%20patrol%2FPawPatrolFolder%2F07%20-%20Die%20Handtaschendiebe%203.ogg
&source=%2Fpaw%20patrol%2FPawPatrolFolder%2F08%20-%20Die%20Bergtour%201.ogg
&source=%2Fpaw%20patrol%2FPawPatrolFolder%2F09%20-%20Die%20Bergtour%202.ogg
&source=%2Fpaw%20patrol%2FPawPatrolFolder%2F10%20-%20Die%20Bergtour%203.ogg
&target=%2FPawPatroltest.taf

Response: 
ok

@inonoob
Copy link
Author

inonoob commented Nov 9, 2024

Noooo Way !!!!

It is a browser topic !!!

Firefox ==> malforms the request !!

Here is the request which works for Chromium which is not working in firefox

Request: 

source=%2Fpaw%20patrol%2FPawPatrolFolder%2F01%20-%20Der%20Gestohlene%20Honig%201.ogg
&source=%2Fpaw%20patrol%2FPawPatrolFolder%2F02%20-%20Der%20Gestohlene%20Honig%202.ogg
&source=%2Fpaw%20patrol%2FPawPatrolFolder%2F03%20-%20Der%20Gestohlene%20Honig%203.ogg
&source=%2Fpaw%20patrol%2FPawPatrolFolder%2F04%20-%20Der%20Gestohlene%20Honig%204.ogg
&source=%2Fpaw%20patrol%2FPawPatrolFolder%2F05%20-%20Die%20Handtaschendiebe%201.ogg
&source=%2Fpaw%20patrol%2FPawPatrolFolder%2F06%20-%20Die%20Handtaschendiebe%202.ogg
&source=%2Fpaw%20patrol%2FPawPatrolFolder%2F07%20-%20Die%20Handtaschendiebe%203.ogg
&source=%2Fpaw%20patrol%2FPawPatrolFolder%2F08%20-%20Die%20Bergtour%201.ogg
&source=%2Fpaw%20patrol%2FPawPatrolFolder%2F09%20-%20Die%20Bergtour%202.ogg
&source=%2Fpaw%20patrol%2FPawPatrolFolder%2F10%20-%20Die%20Bergtour%203.ogg
&source=%2Fpaw%20patrol%2FPawPatrolFolder%2F11%20-%20Die%20Bergtour%204.ogg
&source=%2Fpaw%20patrol%2FPawPatrolFolder%2F12%20-%20Der%20Affen-Naut%201.ogg
&source=%2Fpaw%20patrol%2FPawPatrolFolder%2F13%20-%20Der%20Affen-Naut%202.ogg
&source=%2Fpaw%20patrol%2FPawPatrolFolder%2F14%20-%20Der%20Affen-Naut%203.ogg
&target=%2Fpaw%20patrol%2FPawPatrolFolder%2FPawPatroltestfile.

Response: 
ok

I did test Firefox on two different PCs.
Firefox 130.0.1 & 132.0.1 ==> conversion not working and breaking the path
Version 130.0.6723.91 ==> Working without issues

Strange as No-script & ublock is not activated on both firefox

@inonoob inonoob changed the title [Potential Bug] TAF bulk converting limited to 10 tracks - Potential folder naming conventation issue [Potential Bug] Firefox malfrom library post request breaking folder path Nov 9, 2024
@inonoob
Copy link
Author

inonoob commented Nov 9, 2024

@henryk86 could you retry with Firefox on your pc to confirm it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants