Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A couple of bugs in run() #1

Open
kpbuvic opened this issue Jun 30, 2023 · 1 comment
Open

A couple of bugs in run() #1

kpbuvic opened this issue Jun 30, 2023 · 1 comment

Comments

@kpbuvic
Copy link

kpbuvic commented Jun 30, 2023

  1. In run(), there are the lines
    sp.add_wp(home[0],home[1],alt,speed,wait)
    sp.land()

I think these should be
self.add_wp(home[0],home[1],alt,speed,wait)
self.land()

  1. The definition of run() looks like this:
    def run(self,home:list,pts:list[list[float]], alt:int, speed:int, wait:int):

    but in Python3, this resulted in "TypeError: 'type' object is not subscriptable".

This modified definition does not result in an error:
def run(self,home:list,pts:list, alt:int, speed:int, wait:int):

@tonydavis629
Copy link
Owner

You're absolutely right. Please feel free to make a PR and I'll merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants