Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Writing prefix tags #38

Open
acesnik opened this issue Apr 4, 2018 · 2 comments
Open

Writing prefix tags #38

acesnik opened this issue Apr 4, 2018 · 2 comments
Labels
Enhancement New feature or request
Milestone
ProForma 2.0

Comments

@acesnik
Copy link
Contributor

acesnik commented Apr 4, 2018

Currently, the writer doesn't write prefix tags. Should we extend the writer to do this?
@acesnik acesnik added the Enhancement New feature or request label Apr 4, 2018
@rfellers
Copy link
Member

rfellers commented Apr 5, 2018

Commented on the PR before I saw this ... yes, I'm in favor, but wasn't sure what that should look like. Maybe something like writer.WriteString(bool usePrefixTagIfValid)?

@acesnik
Copy link
Contributor Author

acesnik commented Sep 10, 2018

I think we will have to add a string PrefixTag property to ProFormaTerm to know when to write this back out.

@acesnik acesnik added this to the ProForma 2.0 milestone Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement New feature or request
Projects
None yet
Milestone
ProForma 2.0
Development

No branches or pull requests
2 participants
@rfellers @acesnik