Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tough cases to check #58

Open
2 of 5 tasks
acesnik opened this issue Sep 13, 2018 · 0 comments
Open
2 of 5 tasks

Tough cases to check #58

acesnik opened this issue Sep 13, 2018 · 0 comments
Milestone

Comments

@acesnik
Copy link
Contributor

acesnik commented Sep 13, 2018

Nested brackets

  • PROT[mod:Fe[III]]EOFORM
    Nested brackets need to considered for the fairly common case that they are within descriptors.

Unclosed brackets

  • PROT[info:jk :] lol]EOFORM
    I don't think handling unclosed brackets is worth it, so I'd suggest throwing parsing and writing errors if the number of [ doesn't match that of ].

Back-to-back unclosed brackets

  • PROT[info:jk :] [: lol]EOFORM
  • PROT[info:unclosed][brackets]EOFORM
  • PROT[info:Unclosed]B[rackets]EOFORM
    These are wacky, considering back-to-back unclosed brackets within descriptors. These will lead to unexpected behavior because we assume closed brackets are tags. We should consider making a writer exception if the user tries to write these types of unclosed brackets in descriptors.
@acesnik acesnik added this to the ProForma 2.0 milestone Nov 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant