-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace loo::psis with posterior::pareto_khat (when available) #2
Comments
I made a draft of this change in the branch https://github.com/topipa/iwmm/tree/use-posterior-k. Seems to work locally with the current posterior package branch https://github.com/n-kall/posterior/tree/pareto_k (Pull request here) . |
Nice! There's also https://github.com/n-kall/iwmm/tree/posterior-pareto-k in case there is some detail helpful there |
The PR for posterior implementing pareto-k diagnostics is now merged! So this can go ahead, but there might have been some changes since this draft |
That's great! When I made the draft branch, I did not realize you had already done similar changes in your fork. So my changes are mostly duplicate of yours 🙈 I can take a look at both and pick relevant changes from both of them. |
No worries, I forgot to mention my progress earlier.
This sounds perfect! Let me know if you have any questions on the pareto-k functionality in posterior or my attempt in the fork |
I merged #3, so closing this now! |
Currently
loo::psis
is used to calculate the pareto-k diagnostics, but there is work to have apareto_khat
diagnostic function in posterior. Using this instead would remove the dependency onloo
and allow forloo
to suggestiwmm
(as discussed here).I can make a branch implementing this change and create a PR once the corresponding functions are merged into posterior
The text was updated successfully, but these errors were encountered: