Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AG-30] Parse git_source section from Gemfile and mark as "internal" Ruby dependencies with organization URLs #27

Open
felipead opened this issue Jan 11, 2018 · 0 comments

Comments

@felipead
Copy link
Contributor

Inside Ruby's Gemfile we can declare a git source with the git_source block. This will give us a git URL were bundler should fetch the package from. Example:

git_source(:acme) do |repo_name|
  "https://x-oauth-basic:[email protected]/acme/#{repo_name}.git"
end

Then we can declare packages like:

gem 'foo-sdk', acme: 'foo-ruby-sdk', tag: 'v2017.10.16'
gem 'graphitti', acme: 'graphitti'
gem 'hyperfoo-rb', acme: 'hyperfoo-rb'
gem 'neo_form', acme: 'neo_form'
gem 'neo_list', acme: 'neo_list'
gem 's3d', acme: 's3d', branch: 'add_remote_name_flag'
gem 'top-rspec-matchers', acme: 'top-rspec-matchers'
gem 'declutter', acme: 'declutter'

We should mark these dependencies as "internal", and not process them.

To make this detection organization-agnostic, we can match the GitHub url that was given as input to license-cop with the url declared inside the git_source block.

@felipead felipead changed the title [AG-30] Parse git_source section from Gemfile and mark as "internal" Ruby dependencies with Toptal URLs [AG-30] Parse git_source section from Gemfile and mark as "internal" Ruby dependencies with organization URLs Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant