From 9e6c0e8e26aa27467b8a704a5c3c63b4dfbd6162 Mon Sep 17 00:00:00 2001 From: Vedran Ivanac Date: Mon, 16 Dec 2024 13:12:50 +0100 Subject: [PATCH] Upgrade to Node v20 --- .github/workflows/ci.yaml | 8 ++++---- .github/workflows/danger.yaml | 2 +- .github/workflows/davinci-integration-tests.yml | 10 +++++----- .github/workflows/release.yml | 16 ++++++++-------- .github/workflows/visual-testing.yml | 2 +- Dockerfile | 2 +- package.json | 2 +- packages/picasso-codemod/package.json | 2 +- 8 files changed, 22 insertions(+), 22 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index ef66d97b68..71412c9b66 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -5,7 +5,7 @@ on: pull_request: branches: - master # triggers the flow for every PR to master - - "feature/**" # triggers the flow for a PR to a branch like feature/v9 + - 'feature/**' # triggers the flow for a PR to a branch like feature/v9 types: - synchronize # PR was updated @@ -128,7 +128,7 @@ jobs: - name: Set up Node.js uses: actions/setup-node@v4 with: - node-version: 18 + node-version: 20 - name: Check missing changeset uses: toptal/davinci-github-actions/report-missing-changeset@v15.4.1 @@ -203,7 +203,7 @@ jobs: - name: Set up Node.js uses: actions/setup-node@v4 with: - node-version: 18 + node-version: 20 - name: Install dependencies from cache uses: toptal/davinci-github-actions/yarn-install@v15.4.1 @@ -294,7 +294,7 @@ jobs: "BRANCH": "${{ env.BRANCH }}", "PR_ID": "${{ env.PR_ID }}" } - job_timeout: "3600" + job_timeout: '3600' - name: Create Jira Deployment uses: ./.github/actions/create-jira-deployment/ diff --git a/.github/workflows/danger.yaml b/.github/workflows/danger.yaml index e62cbd829c..736110bf12 100644 --- a/.github/workflows/danger.yaml +++ b/.github/workflows/danger.yaml @@ -46,7 +46,7 @@ jobs: - name: Set up Node.js uses: actions/setup-node@v4 with: - node-version: 18 + node-version: 20 - uses: toptal/davinci-github-actions/yarn-install@v15.4.1 diff --git a/.github/workflows/davinci-integration-tests.yml b/.github/workflows/davinci-integration-tests.yml index b050492f8a..89302eda40 100644 --- a/.github/workflows/davinci-integration-tests.yml +++ b/.github/workflows/davinci-integration-tests.yml @@ -54,7 +54,7 @@ jobs: - name: Set up Node.js uses: actions/setup-node@v4 with: - node-version: 18 + node-version: 20 - uses: toptal/davinci-github-actions/yarn-install@v15.4.1 @@ -64,7 +64,7 @@ jobs: - name: Cache built packages uses: actions/cache@v3 with: - path: "packages/**/dist-package" + path: 'packages/**/dist-package' key: ${{ runner.os }}-pkgs-${{ github.run_id }} }} integration-tests: @@ -113,14 +113,14 @@ jobs: - name: Set up Node.js uses: actions/setup-node@v4 with: - node-version: 18 + node-version: 20 - uses: toptal/davinci-github-actions/yarn-install@v15.4.1 - name: Get cached packages uses: actions/cache@v3 with: - path: "packages/**/dist-package" + path: 'packages/**/dist-package' key: ${{ runner.os }}-pkgs-${{ github.run_id }} }} - name: Run integration tests @@ -172,7 +172,7 @@ jobs: - name: Set up Node.js uses: actions/setup-node@v4 with: - node-version: 18 + node-version: 20 - uses: toptal/davinci-github-actions/yarn-install@v15.4.1 diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 14b7a9e2e9..080d4ef243 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -78,7 +78,7 @@ jobs: - name: Set up Node.js uses: actions/setup-node@v4 with: - node-version: 18 + node-version: 20 - name: Get yarn cache directory path id: yarn-cache-dir-path @@ -190,7 +190,7 @@ jobs: { "COMMIT_ID": "${{ github.sha }}" } - job_timeout: "7200" + job_timeout: '7200' - name: Send a Slack notification on failure if: ${{ failure() }} @@ -200,15 +200,15 @@ jobs: FAILURE_URL: ${{ steps.trigger-deploy.outputs.jenkins_job_url || steps.trigger-build.outputs.jenkins_job_url }} FALLBACK_URL: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}?check_suite_focus=true with: - channel-id: "-frontend-exp-team-notifications" - slack-message: ":x: Current master version of Picasso is <${{ env.FAILURE_URL || env.FALLBACK_URL }}|broken>." + channel-id: '-frontend-exp-team-notifications' + slack-message: ':x: Current master version of Picasso is <${{ env.FAILURE_URL || env.FALLBACK_URL }}|broken>.' - name: Send a Slack notification on success release if: ${{ success() && steps.changesets.outputs.published == 'true' }} uses: slackapi/slack-github-action@v1.27.0 with: - channel-id: "-frontend-exp-team-notifications" - slack-message: "Current master version of Picasso successfully released :green_heart:" + channel-id: '-frontend-exp-team-notifications' + slack-message: 'Current master version of Picasso successfully released :green_heart:' env: SLACK_BOT_TOKEN: ${{ env.SLACK_BOT_TOKEN }} @@ -216,8 +216,8 @@ jobs: if: ${{ success() && steps.changesets.outputs.published != 'true'}} uses: slackapi/slack-github-action@v1.27.0 with: - channel-id: "-frontend-exp-team-notifications" - slack-message: "A new PR was merged to Picasso :parrotspin:" + channel-id: '-frontend-exp-team-notifications' + slack-message: 'A new PR was merged to Picasso :parrotspin:' env: SLACK_BOT_TOKEN: ${{ env.SLACK_BOT_TOKEN }} diff --git a/.github/workflows/visual-testing.yml b/.github/workflows/visual-testing.yml index 26f2595154..e999a59776 100644 --- a/.github/workflows/visual-testing.yml +++ b/.github/workflows/visual-testing.yml @@ -59,7 +59,7 @@ jobs: - name: Set up Node.js uses: actions/setup-node@v4 with: - node-version: 18 + node-version: 20 - uses: toptal/davinci-github-actions/yarn-install@v15.4.1 diff --git a/Dockerfile b/Dockerfile index 583f8b874c..625780dbe9 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,5 +1,5 @@ # syntax=docker/dockerfile:1 -FROM node:18-alpine +FROM node:20-alpine ENV PATH="${PATH}:/app/node_modules/.bin" \ # Installs Chromium (77) package. diff --git a/package.json b/package.json index b173bf1de7..486bd8ffb4 100644 --- a/package.json +++ b/package.json @@ -193,7 +193,7 @@ "zx": "^8.0.2" }, "engines": { - "node": ">=18" + "node": ">=20" }, "files": [ "src" diff --git a/packages/picasso-codemod/package.json b/packages/picasso-codemod/package.json index 5ae2295abb..0d3118ded5 100644 --- a/packages/picasso-codemod/package.json +++ b/packages/picasso-codemod/package.json @@ -48,6 +48,6 @@ "src" ], "engines": { - "node": ">=18" + "node": ">=20" } }