Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FX-4539] Update notistack #4083

Merged
merged 3 commits into from
Jan 12, 2024

Conversation

sashuk
Copy link
Contributor

@sashuk sashuk commented Jan 8, 2024

FX-4539

Description

This pull request bumps notistack package version.

How to test

Development checks

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@sashuk sashuk self-assigned this Jan 8, 2024
Copy link

changeset-bot bot commented Jan 8, 2024

🦋 Changeset detected

Latest commit: 7ddb4f5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@toptal/picasso-provider Patch
@toptal/picasso Patch
@toptal/picasso-shared Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sashuk sashuk force-pushed the fx-4539-reduce-number-of-npm-warnings-notistack branch from 99157db to 952c2d6 Compare January 8, 2024 18:21
@sashuk
Copy link
Contributor Author

sashuk commented Jan 8, 2024

@toptal-bot run package:alpha-release

@toptal-devbot
Copy link
Collaborator

Your alpha package is ready 🎉
yarn add @topkit/analytics-charts@53.0.1-alpha-fx-4539-reduce-number-of-npm-warnings-notistack-1e014be9e.29+1e014be9e
yarn add @toptal/picasso@42.2.5-alpha-fx-4539-reduce-number-of-npm-warnings-notistack-1e014be9e.2+1e014be9e
yarn add @toptal/picasso-charts@56.0.1-alpha-fx-4539-reduce-number-of-npm-warnings-notistack-1e014be9e.29+1e014be9e
yarn add @toptal/picasso-codemod@5.6.4-alpha-fx-4539-reduce-number-of-npm-warnings-notistack-1e014be9e.79+1e014be9e
yarn add @toptal/picasso-forms@66.1.2-alpha-fx-4539-reduce-number-of-npm-warnings-notistack-1e014be9e.24+1e014be9e
yarn add @toptal/picasso-pictograms@2.0.1-alpha-fx-4539-reduce-number-of-npm-warnings-notistack-1e014be9e.149+1e014be9e
yarn add @toptal/picasso-provider@3.4.3-alpha-fx-4539-reduce-number-of-npm-warnings-notistack-1e014be9e.21+1e014be9e
yarn add @toptal/picasso-query-builder@1.2.1-alpha-fx-4539-reduce-number-of-npm-warnings-notistack-1e014be9e.17+1e014be9e
yarn add @toptal/picasso-rich-text-editor@10.0.1-alpha-fx-4539-reduce-number-of-npm-warnings-notistack-1e014be9e.29+1e014be9e
yarn add @toptal/picasso-shared@13.1.3-alpha-fx-4539-reduce-number-of-npm-warnings-notistack-1e014be9e.2+1e014be9e
yarn add @toptal/picasso-tailwind@1.0.2-alpha-fx-4539-reduce-number-of-npm-warnings-notistack-1e014be9e.9+1e014be9e

@sashuk sashuk marked this pull request as ready for review January 9, 2024 10:05
@sashuk sashuk requested review from augustobmoura and removed request for dmaklygin and mkrl January 10, 2024 17:47
@sashuk sashuk force-pushed the fx-4539-reduce-number-of-npm-warnings-notistack branch from 1e014be to 5eb9128 Compare January 10, 2024 17:48
@sashuk sashuk requested review from a team, dmaklygin and mkrl and removed request for a team January 10, 2024 17:48
@sashuk
Copy link
Contributor Author

sashuk commented Jan 10, 2024

@toptal-anvil ping reviewers

@sashuk sashuk force-pushed the fx-4539-reduce-number-of-npm-warnings-notistack branch 3 times, most recently from cc7ef4c to c01aad1 Compare January 12, 2024 10:11
@sashuk
Copy link
Contributor Author

sashuk commented Jan 12, 2024

@toptal-anvil ping reviewers

@sashuk sashuk force-pushed the fx-4539-reduce-number-of-npm-warnings-notistack branch from c01aad1 to 3cdeb97 Compare January 12, 2024 14:18
@sashuk sashuk force-pushed the fx-4539-reduce-number-of-npm-warnings-notistack branch from 3cdeb97 to 7ddb4f5 Compare January 12, 2024 16:18
@sashuk sashuk merged commit 147fd70 into master Jan 12, 2024
18 checks passed
@sashuk sashuk deleted the fx-4539-reduce-number-of-npm-warnings-notistack branch January 12, 2024 16:35
@toptal-build toptal-build mentioned this pull request Jan 12, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants