Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throttling limits preventing test scripting #2

Open
lancegliser opened this issue Jun 5, 2020 · 1 comment
Open

Throttling limits preventing test scripting #2

lancegliser opened this issue Jun 5, 2020 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@lancegliser
Copy link
Member

The current 10 requests per second limit end up causing most of the tests to fail. This will only get worse over time as more end points are added. I reached out to Brian Sweeter at SimilarWeb to see if there's perhaps an alternate environment we can hit that isn't throttle as strictly.

Depending on the answer, we could use the onRequest hook in Service to introduce some sort of queuing service that can use promise delay chains to run through them.

@lancegliser lancegliser added bug Something isn't working good first issue Good for newcomers enhancement New feature or request and removed bug Something isn't working labels Jun 5, 2020
@lancegliser
Copy link
Member Author

Suggestion from Jeff Ding, the architect on their side:
Use the retry options within Axios. If the response code is 429, retry until it succeeds. We'd want to apply a 100 ms delay between to avoid hammering them.

@opensource-torchai opensource-torchai added bug Something isn't working and removed enhancement New feature or request labels Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants