Skip to content

Conversation

@isabellachou
Copy link
Collaborator

Summary

Closes #242

Changes

  • Removed the old yarn.lock
  • Then re-installed yarn

@vercel
Copy link

vercel bot commented Apr 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
toriis ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2025 3:00am

@isabellachou
Copy link
Collaborator Author

Summary

Closes #242

Changes

  • change the import to import Link from 'next/link'
  • remove everything under <Link ... > in line 20 except for className={navStyle} and to={dataKey.path}
  • change to={dataKey.path} to href={'#' + dataKey.path}
  • add onNavigate for smooth scrolling to sections in the homepage
  • URL stays at 'home'

kennykos
kennykos previously approved these changes May 2, 2025
Copy link
Member

@kennykos kennykos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@kennykos kennykos changed the base branch from main to lg/tare-mobile May 2, 2025 00:11
@kennykos kennykos changed the base branch from lg/tare-mobile to main May 2, 2025 00:12
@kennykos kennykos changed the base branch from main to lg/tare-mobile May 2, 2025 00:12
@kennykos kennykos changed the base branch from lg/tare-mobile to main May 2, 2025 00:13
@kennykos kennykos self-requested a review May 2, 2025 00:14
@kennykos kennykos dismissed their stale review May 2, 2025 00:15

We need to merge lg/tare-page into this branch before merge this into main.

@kennykos kennykos requested a review from lizageorge May 2, 2025 03:07
@lizageorge
Copy link
Collaborator

Unfortunately, I think there are more conflicts with the new Next versions. When I go to an investments tare page (like Investments > click on a company card, like this), I get the following error:

image

I get this error even when I pull the link on an Incognito tab, but not on the live Toriis site (thankfully 😭)

@kennykos
Copy link
Member

kennykos commented May 6, 2025

Running yarn add apexcharts fixed the issue for me. A quick git diff shows

diff --git a/package.json b/package.json
index 3964dfb..c2e5bad 100644
--- a/package.json
+++ b/package.json
@@ -24,7 +24,7 @@
     "@trpc/react-query": "^10.9.0",
     "@trpc/server": "^10.9.0",
     "@vercel/analytics": "^1.0.0",
-    "apexcharts": "^3.37.1",
+    "apexcharts": "^4.7.0",
     "clsx": "^1.2.1",
     "contentful": "^9.3.5",
     "flowbite": "^1.6.4",
diff --git a/yarn.lock b/yarn.lock
index be34e51..39fbb26 100644
--- a/yarn.lock
+++ b/yarn.lock

so it looks like all that was needed was an ApexCharts update :). @lizageorge, @isabellachou let me know if this works for you, and then @isabellachou can commit the change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants