Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul Containers #363

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Overhaul Containers #363

merged 1 commit into from
Sep 6, 2023

Conversation

da2ce7
Copy link
Contributor

@da2ce7 da2ce7 commented Aug 6, 2023

Depends on #391

Ready for Review. :)

Big Update for Containers.

  • Rework Dockerfile
  • Rework Container Workflow
  • Rework Docker Compose File
  • Rework Environmental Variables

Todo:

  • Review Documentation.
  • Rebase and Make Good Commit History

Moved to a new issue:

@da2ce7 da2ce7 force-pushed the 20230804_docker_work branch 2 times, most recently from 8200bba to 9c881eb Compare August 6, 2023 21:13
@codecov
Copy link

codecov bot commented Aug 6, 2023

Codecov Report

Merging #363 (5da5a25) into develop (710548b) will increase coverage by 0.21%.
The diff coverage is 62.50%.

@@             Coverage Diff             @@
##           develop     #363      +/-   ##
===========================================
+ Coverage    83.98%   84.19%   +0.21%     
===========================================
  Files          102      102              
  Lines         7182     7208      +26     
===========================================
+ Hits          6032     6069      +37     
+ Misses        1150     1139      -11     
Files Changed Coverage Δ
contrib/bencode/src/reference/decode.rs 96.20% <ø> (ø)
src/servers/apis/mod.rs 100.00% <ø> (ø)
src/servers/apis/v1/middlewares/auth.rs 96.42% <ø> (ø)
src/tracker/databases/driver.rs 87.50% <ø> (ø)
src/tracker/mod.rs 96.23% <ø> (ø)
packages/configuration/src/lib.rs 81.25% <54.54%> (-0.74%) ⬇️
src/lib.rs 62.12% <55.55%> (ø)
src/bootstrap/config.rs 100.00% <100.00%> (+100.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@josecelano

This comment was marked as resolved.

@da2ce7 da2ce7 force-pushed the 20230804_docker_work branch 2 times, most recently from 79ed4ce to 52a0a82 Compare August 7, 2023 13:47
@da2ce7 da2ce7 force-pushed the 20230804_docker_work branch 10 times, most recently from 39c3912 to 2e26d71 Compare August 24, 2023 21:27
@da2ce7 da2ce7 changed the title Rework Dockerfile Improve Container Files Aug 24, 2023
@da2ce7 da2ce7 marked this pull request as ready for review August 24, 2023 21:28
@da2ce7 da2ce7 requested a review from josecelano August 24, 2023 21:30
@da2ce7 da2ce7 force-pushed the 20230804_docker_work branch 7 times, most recently from fc76313 to a75a96a Compare August 25, 2023 13:59
@da2ce7
Copy link
Contributor Author

da2ce7 commented Aug 25, 2023

@josecelano I am starting to become happy with our Dockerfile now. :)

@da2ce7 da2ce7 force-pushed the 20230804_docker_work branch from 4bfbc2c to 971b26e Compare August 25, 2023 21:01
@da2ce7 da2ce7 changed the title Improve Container Files Overhaul Containers Aug 26, 2023
@da2ce7 da2ce7 force-pushed the 20230804_docker_work branch from 7d4178f to dcbf9bf Compare August 26, 2023 21:29
@da2ce7 da2ce7 force-pushed the 20230804_docker_work branch 4 times, most recently from 96215e7 to 734f9ee Compare August 27, 2023 21:19
@da2ce7
Copy link
Contributor Author

da2ce7 commented Aug 27, 2023

@josecelano Starting to Look More Complete. Need to continue reworking documentation.

@da2ce7 da2ce7 added the Needs Rebase Base Branch has Incompatibilities label Aug 27, 2023
@da2ce7 da2ce7 force-pushed the 20230804_docker_work branch 2 times, most recently from 6efb901 to 0770467 Compare August 29, 2023 17:31
@da2ce7 da2ce7 removed the Needs Rebase Base Branch has Incompatibilities label Aug 29, 2023
@da2ce7 da2ce7 force-pushed the 20230804_docker_work branch 4 times, most recently from 7d78e8e to 88d7f49 Compare August 29, 2023 18:08
@da2ce7
Copy link
Contributor Author

da2ce7 commented Aug 29, 2023

@josecelano I believe that this Pull Request is Ready to Review. :)

@da2ce7 da2ce7 force-pushed the 20230804_docker_work branch 2 times, most recently from 013dd67 to 9e9ebbf Compare August 30, 2023 07:45
@da2ce7 da2ce7 had a problem deploying to dockerhub-torrust August 30, 2023 07:54 — with GitHub Actions Failure
@da2ce7 da2ce7 force-pushed the 20230804_docker_work branch from 9e9ebbf to 2942a15 Compare August 30, 2023 10:04
Copy link
Member

@josecelano josecelano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. I've only made minor comments.

.github/workflows/container.yaml Outdated Show resolved Hide resolved
.github/workflows/container.yaml Show resolved Hide resolved
Containerfile Outdated Show resolved Hide resolved
Containerfile Show resolved Hide resolved
@da2ce7 da2ce7 force-pushed the 20230804_docker_work branch 5 times, most recently from b7e52e0 to 0e90be0 Compare September 6, 2023 06:43
@da2ce7 da2ce7 force-pushed the 20230804_docker_work branch from 0e90be0 to 5da5a25 Compare September 6, 2023 09:11
@da2ce7
Copy link
Contributor Author

da2ce7 commented Sep 6, 2023

ACK 5da5a25

@da2ce7 da2ce7 merged commit 7d133ae into torrust:develop Sep 6, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Review Docker Publishing Workflows
2 participants