Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argument deployment inconsistent between Jobs and Triggers. #55

Open
jensuffhaus opened this issue Jan 15, 2024 · 0 comments
Open

Argument deployment inconsistent between Jobs and Triggers. #55

jensuffhaus opened this issue Jan 15, 2024 · 0 comments

Comments

@jensuffhaus
Copy link

AWS Glue requires arguments to begin with "--".

It's a little wierd and AWS should do this behind the scenes, but it is what it is.

The plugin deploys a Job correctly and adds the "--" to the beginning of default arguments if they are not there in the yml already. This is great. "src/utils/cloud-formation.utils.ts:98-100"

However, triggers in glue can override these arguments and they also must begin with "--". Unfortunately, this plugin does not automatically check/prefix the argument for triggers the same way it does with the job itself. Developers can/must include the "--" in the yml. This is a little inconsistent and the same approach should be used for both. Either check and prepend or check and fail if they are missing. "src/utils/cloud-formation.utils.ts:120"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant