Skip to content

Conversation

@leegeunhyeok
Copy link
Collaborator

Description

Expose resolver.resolveRequest option and remove unsupported options (unstable_XXX options are not supported in the base Metro version 0.72.3 used by Granite)

image 스크린샷 2025-11-05 오후 9 57 41
{
  name: 'metro-resolver-test',
  config: {
    metro: {
      resolver: {
        conditionNames: ['foo', 'bar'],
        resolverMainFields: ['a', 'b', 'c'],
        resolveRequest: (_context, moduleName, platform) => {
          console.log('[DEBUG] resolveRequest', moduleName, platform);
        },
      },
    },
  },
}

@changeset-bot
Copy link

changeset-bot bot commented Nov 5, 2025

🦋 Changeset detected

Latest commit: eb222ce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 21 packages
Name Type
@granite-js/plugin-core Patch
@granite-js/mpack Patch
@granite-js/cli Patch
@granite-js/plugin-env Patch
@granite-js/plugin-hermes Patch
@granite-js/plugin-micro-frontend Patch
@granite-js/plugin-router Patch
@granite-js/plugin-sentry Patch
@granite-js/react-native Patch
@granite-js/forge-cli Patch
babel-preset-granite Patch
create-granite-app Patch
@granite-js/devtools-frontend Patch
@granite-js/image Patch
@granite-js/jest Patch
@granite-js/lottie Patch
@granite-js/native Patch
@granite-js/style-utils Patch
@granite-js/utils Patch
@granite-js/deployment-manager Patch
@granite-js/pulumi-aws Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 5, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
granite-docs Ready Ready Preview Comment Nov 5, 2025 1:06pm

@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

❌ Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 6.42%. Comparing base (e957833) to head (eb222ce).

Files with missing lines Patch % Lines
packages/mpack/src/metro/getMetroConfig.ts 0.00% 7 Missing ⚠️
packages/mpack/src/metro/enhancedResolver.ts 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #154      +/-   ##
========================================
- Coverage   6.42%   6.42%   -0.01%     
========================================
  Files        466     466              
  Lines      21566   21567       +1     
  Branches     733     733              
========================================
  Hits        1386    1386              
- Misses     19831   19832       +1     
  Partials     349     349              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants